Ease reviewing of specific discussions resolutions.

Description

With some of our (previously gerrit using) developers getting started with gitalb review, we're having trouble during review knowing how a discussion has been resolved.

For example, a merge request is pushed, reviewer makes a comment on a line. Developer pushes a change, follows up the comment saying "Done" review1

Reviewer comes back and wants to know how it's been fixed.

At the moment, I can still scroll down, find the discussion entry for the new commit and hit "Compare with previous version" This gives me the diff I want of the commit that's supposedly fixed the discussion, but then I get the notification: "Comments are disabled because you're comparing two versions of this merge request"

Also if its a big commit addressing a few comments it can be difficult to find the right place for the change.

Alternatively, if developer makes a series of commits to address a number of review comments, it's hard to figure out which one's which. Developer could/should put a commit hash note in the discussion as opposed to just Done, but I don't think that would turn into a diff link, just a link to the commit?

In the diff view, I understand not being able to make new comments on old versions, but this view should show existing comments sitting side-by-side similar to when viewing diff of latest vs master. This way it would be easy to review the specific change made to address the discussion.

Proposal

  • In a discussion on a line of code, it would be ideal to detect changes to the same hunk in new commits and add that snippet to the discussion automatically.
  • Alternately, in a discussion on code line, It would be good to have a link to compare the version the comment was made on to latest commit and in the diff view show the comment next to the change that's fixed it.
  • When diffing two versions of a merge request, show existing comments that were made on either of the versions.

Documentation blurb

(Write the start of the documentation of this feature here, include:

  1. In code discussions, we want to make it easier to follow related code changes