Refactor RavenConfig to follow singleton guidelines
Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/6764#note_28920332
I wrote a singleton originally as an object literal. Because our guidelines state that object literals as singletones are bad, I had to refactor it into a class.
Turns out this is pretty time consuming in order to simply add complexity to the object. I highlighted one of these issues in the comment above.
I will be asking about our singleton approach in the team call next week so will decide what to do about this refactor after that. I will be skipping the refactor for now because the change has such a small impact and we want this MR for the upcoming milestone.