Blocked User appears on MR approvers list.

Summary

A blocked user to the project appears on the approver's list of a merge request. Although he is not capable of accepting the merge or even accessing the project, his name appears on the list.

Example:

Requires 1 more approval (from Gollum, Gandalf the Grey, The Necromancer, Gimli or Aragorn)

On the list of approvers, appears Gollum which is a blocked user to the project (and to the Gitlab system).

Steps to reproduce

1 - Add Gollum to the list of members of the Lord of the Rings project 2 - Let Gollum run a few commits, merges, etc 3 - Block Gollum systemwide (/admin/users) on the Gitlab application (you don't want to delete at this point because you will loose Gollum commits, merges, etc. History is important). 4 - Ask another project member to do a merge request, Gandalf for instance.

On that merge request, you should see:

Requires 1 more approval (from Gollum, Gandalf the Grey, The Necromancer, Gimli or Aragorn)

What is the current bug behavior?

Display issue. Not critical.

What is the expected correct behavior?

On the list of merge request approvers, Gollum, which is the blocked project member, should not appear as a possible approver.

Requires 1 more approval (from Gandalf the Grey, The Necromancer, Gimli or Aragorn)

Relevant logs and/or screenshots

n/a

Output of checks

This bug happens on a hosted version of Gitlab EE.

Results of GitLab environment info

GitLab 8.16.1-ee
GitLab Shell 4.1.1
GitLab Workhorse v1.3.0
GitLab API v3
Git 2.10.2
Ruby 2.3.3p222
Rails 4.2.7.1
PostgreSQL 9.2.18

Results of GitLab application Check

n/a

Possible fixes

n/a