Replace href='#' with button

Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.

• Close this issue

This issue is a continuation of https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/10571#note_27269541

The idea is to replace <a href='#'> with <button> because <button> is more semantic.

However, there was some concern's regarding the default outline styling whereby we want the outline to show on tab, but not on click (which happens on default for anchors and not buttons).

/cc @annabeldunstone