Removing approver refreshes MR page, losing unsaved changes

Summary

When editing an MR, if you change some of the settings (like the number of approvers, labels, assignee) and then remove an approver, the page refreshes and other changes on the page are lost.

Steps to Reproduce

  1. Open an existing MR with an existing list of approvers
  2. Change the value of "Assignee"
  3. Remove one of the approvers

Expected Behaviour

The removed approver should be removed from the visible list, but the page should not refresh. The removed approver would only be actually removed once "Save Changes" is clicked.

Actual Behaviour

Removing the approver refreshes the page, wiping other changes to the MR.

Side Note

#1651 (closed) suggests removing the pop-up for removing approvers which is line with this issue. The "Confirm Approver Removal" pop-up is like a second "Save Changes" button that only applies to the approver list, which is not intuitive behaviour.

Assignee Loading
Time tracking Loading