Skip to content

New files aren't clearly marked in the diff

Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.

In https://gitlab.com/gitlab-org/gitlab-ee/commit/574b9c6771170ccaf7f0323492ce67a5900acb39, we see that a new file with size of zero kb (0kb) looks like a mode change:

image

This caused a problem in our RC5 deploy, as a blank file with no constants breaks the metrics initialization. This was missed in the review that this was a new file of 0 bytes.

I would expect that that it would be obvious that this was a new file.

Proposal

Display zero size file with the label as we do in the blob view.

Example from blob view: CleanShot_2023-11-01_at_14.15.56

Edited by 🤖 GitLab Bot 🤖