Checking the correct behaviour for commit status

Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.

• Label this issue
• Close this issue

Summary

Please can you confirm if this is the correct behaviour / expected view for commit statuses when reported by external jobs?

I'd expect to only see one status line that is updated as it changes.

Steps to reproduce

A POST request is made to the commit status endpoint (https://docs.gitlab.com/ce/api/commits.html#post-the-build-status-to-a-commit) three times with the following params:

state: pending
ref: master
name: jobname
description: My example description

state: running
ref: master
name: jobname
description: My example description

state: failed
ref: master
name: jobname
description: My example description

Expected behavior

One status row is shown with the latest status (in this case, failed).

Actual behavior

Three status rows are shown, two with the "Retried" flag.

Relevant logs and/or screenshots

Output of checks

This bug happens on GitLab.com

Possible fixes

No idea for a possible fix. I assume the related code is:

https://gitlab.com/gitlab-org/gitlab-ce/blob/master/app/models/commit_status.rb

https://gitlab.com/gitlab-org/gitlab-ce/blob/master/app/models/concerns/has_status.rb