Expirable models should validate that `expires_at` is not in the past
We have an Expirable
concern that is used in models such as 'ProjectGroupLink'. This allows us to set future expiration on group shares, membership, etc. Currently, it's not enforced in the model that the expires_at
date is in the future. The frontend makes sure you cannot do this via the UI but nothing enforces it via Rails console or the API. It should be fairly easy to add a validation that ensure it's set in the future.
We should also add a migration here that checks for expired things as I know at least one customer does have old group shares and I'm not sure if they'll be cleaned up on the next expiration run. I'll ask them to check and get back to us.