Encoding of user name (html entities) still double encodes - Example - put an ampersand in the name

Summary

If you put an ampersand in the name of a user - it displays it in the UI double encoded - i.e. "S&T Student" will display when shown in listings/project page/etc. as "S&T Student".

Steps to reproduce

Go to edit a user, put an & in their name.

In my case, this is coming from LDAP, but can reproduce with simple edit.

Expected behavior

Store encoded, display singly-encoded, or store raw and display singly-encoded.

It should show "S&T Student" in the output.

Actual behavior

It shows "S&T Student"

Relevant logs and/or screenshots

I can get a screenshot if you really need, but symptom should be pretty obvious.

Output of checks

Results of GitLab application Check

NA - behavioral issue, not an environment problem. Running 8.12 though.

Results of GitLab environment info

NA - behavioral issue, not an environment problem. Running 8.12 though.

Possible fixes