Backend: Rename CI classes to better reflect CI domain
Proposal
- Rename
CommitstatustoCi::Job - Rename
GenericCommitStatustoCi::ExternalJob
Old proposal
We want to introduce multi-project pipelines soon, but this requires some minor architecture changes of underlying domain model, to make it easier to implement a new feature.
Changing few things would simplify the implementation:
- extract common CI job features from
CommitStatustoCi::Jobabstract class - rename
GenericCommitStatustoCi::ExternalJob < Ci::Job - extract general abstract implementation from
Ci::BuildtoCi::Job - inherit from newly created abstract class in
Ci::Build < Ci::Job
This will make it easier to add new job types like Ci::PipelineBridge or Ci::PipelineDependency that would make it easier to implement multi-project pipeline.
Alternative naming convention:
-
Ci::Jobmodule -
Ci::Job::Baseabstract class -
Ci::Job::Externalexternal job -
Ci::Job::Buildbuild -
Ci::Job::BridgeorCi::Job::Dependencyfor pipeline trigger/depedency (or both for different dependency direction)
/cc @ayufan
Edited by Grzegorz Bizon