Skip to content
GitLab
Next
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • GitLab GitLab
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 44,761
    • Issues 44,761
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 1,330
    • Merge requests 1,330
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.orgGitLab.org
  • GitLabGitLab
  • Issues
  • #16111
Closed
Open
Issue created Oct 06, 2016 by Grzegorz Bizon@grzesiek💡Maintainer

Backend: Rename CI classes to better reflect CI domain

Proposal

  • Rename Commitstatus to Ci::Job
  • Rename GenericCommitStatus to Ci::ExternalJob

Old proposal

We want to introduce multi-project pipelines soon, but this requires some minor architecture changes of underlying domain model, to make it easier to implement a new feature.

Changing few things would simplify the implementation:

  • extract common CI job features from CommitStatus to Ci::Job abstract class
  • rename GenericCommitStatus to Ci::ExternalJob < Ci::Job
  • extract general abstract implementation from Ci::Build to Ci::Job
  • inherit from newly created abstract class in Ci::Build < Ci::Job

This will make it easier to add new job types like Ci::PipelineBridge or Ci::PipelineDependency that would make it easier to implement multi-project pipeline.

Alternative naming convention:

  • Ci::Job module
  • Ci::Job::Base abstract class
  • Ci::Job::External external job
  • Ci::Job::Build build
  • Ci::Job::Bridge or Ci::Job::Dependency for pipeline trigger/depedency (or both for different dependency direction)

/cc @ayufan

Edited Aug 08, 2022 by Grzegorz Bizon
Assignee
Assign to
Time tracking