Guest access to issues broke after 8.12 upgrade if changes are made to a project
Summary
Seems there was a change in how guests can access issues after the 8.12 upgrade. It took away the option to allow a "guest" user, who is part of a group, to be able to see things like issues with a guest role. We have users, who are part of a group, who then get shared access to repositories with just "guest" privileges. Before the update we could have them see and report issues and not see code. After update they still have the access, until we make any change to the repository. If we edit anything on its settings the access goes away and I have not been able to figure out how to get it back. I'll try to explain better in steps below...
Steps to reproduce
** Before update to 8.12
- Have an external user on a group
- The group gets added to a repository on the "members" section with the "Set a group to share" option. They get "Guest" role privileges.
- The repository has permissions to allow access to issues
- User can see the issues tab and pretty much not anything else:
** After update to 8.12
- Administrator logs in and makes any change to a project, even if it is just clicking on "Save Changes" without changing anything at all
- Users who had access now lose access to issues:
- Users can still see the titles of the issues, on the "Issues" section of their group, but if they click on any of them they get a 404.
Expected behavior
The users that are part of a group who is shared access to a project with "Guest" roles should be able to see the issues from either the project or from the "issues" section of their group.
Actual behavior
They can see the issues on the group section, but they all 404 on click. They cannot see issues at all in the project.
Possible fixes
Looks like something was changed in 8.12. Running 8.12.1 now and error still there. Looks like a bug since permissions disappear even with no changes made to a project. Plus the users can still see the issues from the groups section, they just can't click on them since they all 404.
Would be happy to provide more information if I wasn't clear on the problem. Thanks!