Skip to content
GitLab Next
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • GitLab GitLab
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 43,153
    • Issues 43,153
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 1,404
    • Merge requests 1,404
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.org
  • GitLabGitLab
  • Issues
  • #15930
Closed
Open
Created Sep 15, 2016 by Philip Chinery@pdfforge

Integrate status checks on merge requests via web hook

Description

Allow the project admins to define status checks that are required to allow a merge request.

When working on a merge request, several conditions might be required for it to be truly good to merge. Hopefully everywhere it is that the CI build passes (which is integrated in GitLab). Often there will be more, i.e. a referenced issue is in the state "ready to merge" or a code review has been performed.

These checks are highly workflow-dependent though.

Proposal

Allow to add additional checks with webhooks. This could include a list of checks that hast to be met and for each check a web hook could be called, that will perform the check and give a json result on the success and additional data (i.e. why the condition is not met or a link to the successful code review).

This way, this would not rely on custom modules deployed by the admins into GitLab and give a lot of flexibility. The configuration could be done in the .gitlab folder, where the templates are not located as well.

Links / references

GitHub allows a few of those, i.e. to integrate AppVeyor and Travis CI: https://help.github.com/enterprise/2.7/admin/guides/developer-workflow/configuring-protected-branches-and-required-status-checks/#enabling-required-status-checks

Assignee
Assign to
Time tracking