Skip to content

Bad UX related to approvers since 8.16.0-ee c13afce5

Hi everyone!

Since today, a MR shows an empty list of approvers:

Screen_Shot_2017-01-23_at_17.34.46

This made me think that the avatar of this potential reviewer did not get loaded and I opened the Chrome devtools, until I realized this was an empty list, and not a bug..

In addition, when the required number of approvers has been reached, I do not think that displaying "0 more approvals" makes sense. I would either expect nothing or "Everything looks good":

Screen_Shot_2017-01-23_at_17.37.33

Regards, William

PS: I tried to find a similar issue to avoid duplicates but I did not find anything at the time of writing.