Sign in or sign up before continuing. Don't have an account yet? Register now to get started.
Register now

Gitlab::Access omitting OWNER by default can cause subtle bugs

Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.

  • Close this issue

This mixin omits the Owner level by default, and can lead to subtle bugs (see https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/2881 and https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5353).

I think it should always return all values/options, and the consuming class should be responsible for "downconverting" Owner to Master if that level doesn't apply for it, such as in a Project.

Further, this module isn't even consistent about how we include the Owner level. We have values/all_values, but then options/options_with_owner, not all_options. Then we have sym_options, with neither all_sym_options nor sym_options_with_owner. 😡

cc @grzesiek

Edited Sep 25, 2025 by 🤖 GitLab Bot 🤖
Assignee Loading
Time tracking Loading