Source Commit Endpoint Service - No Longer Triggered by ID in MR

Summary

Recent updates have caused the Source Commit Endpoint Service to no longer fire when an MR includes the proper ID. I am using the Pivotal Tracker service. Prior to the latest updates, including the text like this in the MR "[#123425132]" would cause the MR commit to trigger the SCE to link the MR commit to the Story in Pivotal Tracker. Now the only way to get it to link is to put the text on an actual commit.

Whatever this change was is disruptive and very undesirable, as it forces us to add the ID to every single commit in branch for the MR. This causes code that is not yet reviewed and approved to be linked. If the branch is modified, rebased, and forced pushed up it also leaves links to non-existent commits to left in the Stories in PT.

Steps to reproduce

  1. Create an MR with the required PT ID in it "[#123425132]" (whatever is appropriate for your PT instance).
  2. Approve and Merge the MR
  3. SCE does not link the MR commit

However - if you include the PT ID in a commit in the branch for the MR, when the branch is pushed up to GitLab the SCE fires and links the commit.

Expected behavior

SCE should fire and link the MR commit to the noted Story in Pivotal Tracker

Actual behavior

SCE is not fired

Relevant logs and/or screenshots

Output of checks

Results of GitLab application Check

Results of GitLab environment info

System information
System:		Ubuntu 14.04
Current User:  	git
Using RVM:     	no
Ruby Version:  	2.3.3p222
Gem Version:   	2.6.6
Bundler Version:1.13.7
Rake Version:  	10.5.0
Sidekiq Version:4.2.7

GitLab information
Version:       	8.15.4-ee
Revision:      	e33b0cb
Directory:     	/opt/gitlab/embedded/service/gitlab-rails
DB Adapter:    	PostgreSQL
DB Version:    	9.2.18
URL:   		https://git.ibaset.com
HTTP Clone URL:	https://git.ibaset.com/some-group/some-project.git
SSH Clone URL: 	git@git.ibaset.com:some-group/some-project.git
Elasticsearch: 	no
Geo:   		no
Using LDAP:    	yes
Using Omniauth:	no

GitLab Shell
Version:       	4.1.1
Repository storage paths:
- default:     	/data00/gitlab/git-data/repositories
Hooks: 		/opt/gitlab/embedded/service/gitlab-shell/hooks/
Git:   		/opt/gitlab/embedded/bin/git

Possible fixes