on Staging, when IP restriction is switched on, project is not accessible via https

Summary

When group has ip restriction switched on and IP is set to current to user (checked on active sessions page) project is accessible via UI, but when user tried to clone it using https - it was returning 404 - project not found. User has proper permissions.

The same feature is working on production and fresh instance of nightly. Unfortunately, the staging logs are not accessible, so I couldn't check it.

Steps to reproduce

  1. Find group on gold plan on **staging ** as owner.
  2. set up IP restriction IP address to yours.
  3. check if project is accessible via UI.
  4. clone project via https.

Example Project

https://staging.gitlab.com/issue-reproduce/testprojectagain

(If you are using an older version of GitLab, this will also determine whether the bug is fixed in a more recent version)

What is the current bug behavior?

Project while cloning through https is not accessible.

What is the expected correct behavior?

Project while cloning through https should be accessible while using IP address matching one in settings.

Relevant logs and/or screenshots

(Paste any relevant logs - please use code blocks (```) to format console output, logs, and code as it's tough to read otherwise.)

Output of checks

(If you are reporting a bug on GitLab.com, write: This bug happens on GitLab.com)

Results of GitLab environment info

Expand for output related to GitLab environment info

(For installations with omnibus-gitlab package run and paste the output of: sudo gitlab-rake gitlab:env:info)

(For installations from source run and paste the output of: sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production)

Results of GitLab application Check

Expand for output related to the GitLab application check

(For installations with omnibus-gitlab package run and paste the output of: sudo gitlab-rake gitlab:check SANITIZE=true)

(For installations from source run and paste the output of: sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true)

(we will only investigate if the tests are passing)

Possible fixes

(If you can, link to the line of code that might be responsible for the problem)

Assignee Loading
Time tracking Loading