Broken master: static-analysis failure

From https://gitlab.com/gitlab-org/gitlab-ee/-/jobs/284734250:

All static analyses passed successfully, but we have warnings:


**** bin/rake lint:all had the following warning(s):

/builds/gitlab-org/gitlab-ee/ee/lib/atlassian/jwt.rb:11: warning: already initialized constant Module::CANONICAL_QUERY_SEPARATOR
/builds/gitlab-org/gitlab-ee/vendor/ruby/2.6.0/gems/atlassian-jwt-0.2.0/lib/atlassian/jwt.rb:9: warning: previous definition of CANONICAL_QUERY_SEPARATOR was here
/builds/gitlab-org/gitlab-ee/ee/lib/atlassian/jwt.rb:12: warning: already initialized constant Module::ESCAPED_CANONICAL_QUERY_SEPARATOR
/builds/gitlab-org/gitlab-ee/vendor/ruby/2.6.0/gems/atlassian-jwt-0.2.0/lib/atlassian/jwt.rb:10: warning: previous definition of ESCAPED_CANONICAL_QUERY_SEPARATOR was here

e3f9cc43 introduced the atlassian-jwt gem as part of the jira-ruby dependency update. The issue is now we have two implementations of this class now, and effectively we have monkey patched the Gem version.

In the short-term, we could just remove CANONICAL_QUERY_SEPARATOR and ESCAPED_CANONICAL_QUERY_SEPARATOR from our version, but I'm not sure if there are other side effects we need to be concerned about.

/cc: @engwan

Edited Aug 31, 2019 by Stan Hu
Assignee Loading
Time tracking Loading