Use view-appropriate empty state in security dashboard
This is a follow-up from https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/15682.
The project Security Dashboard and pipeline Security Dashboard display the same empty state as the group Security Dashboard, with group-specific wording, which is not ideal.
This is because the empty state is hard-coded in the security-dashboard-table component, and was originally intended only for use in the context of a group.
| Project Security Dashboard | Pipeline Security Dashboard (https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/15682) |
|---|---|
 |
 |
The most obvious way to fix this would be to expose a slot (perhaps called empty) in the security-dashboard-app component.
This will also have implications for the eventual use of the dashboard in the MR widget, and the instance-level security dashboard.
Proposal
| Instance dashboard | Group dashboard | Project dashboard | Pipeline |
|---|---|---|---|
 |
 |
 |
 |
| Dashboard | Title | Text | Link |
|---|---|---|---|
| Instance Security Dashboard | No vulnerabilities found for this instance | While it's rare to have no vulnerabilities for your instance, it can happen. In any event, we ask that you double check your settings to make sure you've set up your dashboard correctly. | No docs yet? |
| Group Security Dashboard | No vulnerabilities found for this group | While it's rare to have no vulnerabilities for your group, it can happen. In any event, we ask that you double check your settings to make sure you've set up your dashboard correctly. | user/application_security/security_dashboard/index |
| Project Security Dashboard | No vulnerabilities found for this project | While it's rare to have no vulnerabilities for your project, it can happen. In any event, we ask that you double check your settings to make sure you've set up your dashboard correctly. | user/application_security/security_dashboard/index |
| Pipelines Security Dashboard | No vulnerabilities found for this pipeline | While it's rare to have no vulnerabilities for your pipeline, it can happen. In any event, we ask that you double check your settings to make sure all security scanning jobs have passed successfully. | user/application_security/security_dashboard/index |
Edited by Andy Volpe