Approvals functionality after a merge request has been merged
Problem
- What information to show?
- Should you be able to continue approving? Probably. Should be designed in conjunction with https://gitlab.com/gitlab-org/gitlab-ee/issues/1126.
- That may have an impact on system notifications / emails, etc., and other downstream impacts. Identify those.
Description
After a merge request is accepted, the visibility of approvers goes away. It's possible to dig down in the logs to find out who the approvers were, but why not leave them on the page? I have dev managers who always want to see this. While you're at it, the reviews from actual reviewers shouldn't be buried down in the logs either. Those should be plainly visible as well.
Proposal
The approvers of an MR should remain visible even after a merge request closure or acceptance.
Links / references
Edited by Coung Ngo