Group push-webhooks not called on self-hosted instance since update to 12.2
Summary
This morning (23/08/2019) we updated our self hosted gitlab instance to 12.2.
Ever since, the configured push-webhooks for groups are not executed anymore
When adding a new push-webhook in a project within said group, both push-webhooks are called. Both as in: the project specific webhook and the group push-webhook(s).
When removing the project specific push-webhook, the group push-webhooks are not called anymore.
Steps to reproduce
- Install a self hosted gitlab instance
- Create a group
- Add a push-webhook for that group
- Create a project within that group
- Push to the new project - webhook is not called
- Create a push-webhook within that project
- Push to the new project - both project push-webhook and group push-webhook are called
- Remove project push-webhook
- Push to the new project - group push-webhook is not called anymore
Note: internal request logs confirm that the webhook is indeed not called
Example Project
N/A
What is the current bug behavior?
The group push-webhook are not called when pushing to a project within that group
What is the expected correct behavior?
The group push-webhook are called when pushing to a project within that group
Relevant logs and/or screenshots
N/A
Output of checks
N/A
Results of GitLab environment info
N/A
Results of GitLab application Check
N/A
Possible fixes
The issue could have been introduced in this merge request: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/19513/diffs Although that MR is merged over almost a year ago... so maybe not. It does however touch quite a bit of webhook integration and applies filters on them.