Merge Request Approval with REST API

Summary

This issue is related to issue #1118 (closed)

There were already some fixes for 8.14, but we are still running on version 8.13.2, the mentioned issues about approving a merge request is not solved. When creating and approving a merge request via the REST API, there are inconsistencies compared to the UI and it does not fully work.

Description

Actual behavior

When creating a new merge request by the API we see the following information:
Debug information before Merge

When it is approved by the API, we see the following User Interface in Gitlab: User interface After Merge

The Debug information of the API for the screen above is: AfterMerge

In the last picture, you can see that the "approvals_left" are not decreased and the approver is not registered in the UI as well as in the response of the API call.

Expected behavior

If we do exactly the same flow but this time with the approval in the UI, the UI looks like this: UI After Merge in UI

If you compare this output with the first one, you can see that there are more actions and the approver is registered. The response of the REST call confirms this: Debug information after merge in UI

This means that there are still some inconsistency. Could you please take a look at this?

Edited by Coung Ngo