Features still enabled on GitLab.com but no longer present in code
We have 59 (out of 99) feature flags enabled that seem to be no longer present in the code. Which means they are redundant. Can we delete them via chatops in #production
?
$ cat a.txt | xargs -n1 -IX sh -c 'git grep -q "Feature.enabled.*X\b" || echo 'Feature.enabled.*X' not found in code'
Feature.enabled.*approval_rule not found in code
Feature.enabled.*approval_rules not found in code
Feature.enabled.*background_migration_health_check not found in code
Feature.enabled.*batch_comments not found in code
Feature.enabled.*batch_review_notification not found in code
Feature.enabled.*ci_environments_status_changes not found in code
Feature.enabled.*ci_job_request_with_tags_matcher not found in code
Feature.enabled.*ci_merge_request_pipeline not found in code
Feature.enabled.*ci_preparing_state not found in code
Feature.enabled.*ci_variables_complex_expressions not found in code
Feature.enabled.*clusters_cte not found in code
Feature.enabled.*dependency_list not found in code
Feature.enabled.*diff_suggestions not found in code
Feature.enabled.*diff_tree_filtering not found in code
Feature.enabled.*environment_metrics_use_prometheus_endpoint not found in code
Feature.enabled.*epic_links not found in code
Feature.enabled.*error_tracking not found in code
Feature.enabled.*expand_diff_full_file not found in code
Feature.enabled.*external_authorization_service not found in code
Feature.enabled.*fast_destroy_uploads not found in code
Feature.enabled.*feature_flags_environment_scope not found in code
Feature.enabled.*geo_redownload_with_snapshot not found in code
Feature.enabled.*gfm_embedded_metrics not found in code
Feature.enabled.*gitaly_catfile-cache not found in code
Feature.enabled.*graphql not found in code
Feature.enabled.*group_project_templates not found in code
Feature.enabled.*group_saml_allows_sign_in_to_gitlab not found in code
Feature.enabled.*group_saml_metadata_available not found in code
Feature.enabled.*group_security_dashboard_history not found in code
Feature.enabled.*import_export_object_storage not found in code
Feature.enabled.*issue_suggestions not found in code
Feature.enabled.*issues_import_csv not found in code
Feature.enabled.*merge_trains not found in code
Feature.enabled.*metrics_reports not found in code
Feature.enabled.*metrics_time_window not found in code
Feature.enabled.*multiple_merge_request_assignees not found in code
Feature.enabled.*open_in_xcode not found in code
Feature.enabled.*operation_user_update_branch not found in code
Feature.enabled.*pages_auto_ssl not found in code
Feature.enabled.*pages_auto_ssl_for_project not found in code
Feature.enabled.*paginate_without_count not found in code
Feature.enabled.*parse_container_scanning_reports not found in code
Feature.enabled.*parse_dependency_scanning_reports not found in code
Feature.enabled.*pipeline_dashboard not found in code
Feature.enabled.*prometheus_transaction_build_not_found_total not found in code
Feature.enabled.*prometheus_transaction_event_build_invalid_total not found in code
Feature.enabled.*prometheus_transaction_event_build_not_found_cached_total not found in code
Feature.enabled.*prometheus_transaction_event_build_not_found_total not found in code
Feature.enabled.*prometheus_transaction_event_etag_caching_cache_hit_total not found in code
Feature.enabled.*prometheus_transaction_event_etag_caching_header_missing_total not found in code
Feature.enabled.*prometheus_transaction_event_etag_caching_key_not_found_total not found in code
Feature.enabled.*prometheus_transaction_event_etag_caching_middleware_used_total not found in code
Feature.enabled.*prometheus_transaction_event_etag_caching_resource_changed_total not found in code
Feature.enabled.*prometheus_transaction_event_rails_exception_total not found in code
Feature.enabled.*prometheus_transaction_event_sidekiq_exception_total not found in code
Feature.enabled.*prometheus_transaction_event_stuck_import_jobs_total not found in code
Feature.enabled.*protected_branch_creation not found in code
Feature.enabled.*protected_environments not found in code
Feature.enabled.*releases_page not found in code
Feature.enabled.*remove_disabled_domains not found in code
Feature.enabled.*reply_to_individual_notes not found in code
Feature.enabled.*report_approver_rules not found in code
Feature.enabled.*shared_runner_minutes_on_root_namespace not found in code
Feature.enabled.*store_security_reports not found in code
Feature.enabled.*tablesample_counts not found in code
Feature.enabled.*tag_names not found in code
Feature.enabled.*update_all_mirrors_worker_rescheduling not found in code
Feature.enabled.*update_statistics_namespace not found in code
Feature.enabled.*use_cte_for_group_issues_search not found in code
Feature.enabled.*use_subquery_for_group_issues_search not found in code
Feature.enabled.*variable_masking not found in code
-
/chatops run feature delete approval_rule
-
/chatops run feature delete approval_rules
-
/chatops run feature delete background_migration_health_check
-
/chatops run feature delete batch_comments
-
/chatops run feature delete batch_review_notification
-
/chatops run feature delete ci_environments_status_changes
-
/chatops run feature delete ci_job_request_with_tags_matcher
-
/chatops run feature delete ci_merge_request_pipeline
-
/chatops run feature delete ci_preparing_state
-
/chatops run feature delete ci_variables_complex_expressions
-
/chatops run feature delete clusters_cte
-
In use/chatops run feature delete dependency_list
-
/chatops run feature delete diff_suggestions
-
/chatops run feature delete diff_tree_filtering
-
/chatops run feature delete environment_metrics_use_prometheus_endpoint
-
/chatops run feature delete epic_links
-
/chatops run feature delete error_tracking
-
/chatops run feature delete expand_diff_full_file
-
/chatops run feature delete external_authorization_service
-
/chatops run feature delete fast_destroy_uploads
-
/chatops run feature delete feature_flags_environment_scope
-
/chatops run feature delete geo_redownload_with_snapshot
-
/chatops run feature delete gfm_embedded_metrics
-
/chatops run feature delete gitaly_catfile-cache
-
/chatops run feature delete graphql
- [-]
/chatops run feature delete group_project_templates
-
/chatops run feature delete group_saml_allows_sign_in_to_gitlab
-
/chatops run feature delete group_saml_metadata_available
-
/chatops run feature delete group_security_dashboard_history
-
/chatops run feature delete import_export_object_storage
-
/chatops run feature delete issue_suggestions
-
/chatops run feature delete issues_import_csv
-
/chatops run feature delete merge_trains
-
/chatops run feature delete metrics_reports
-
/chatops run feature delete metrics_time_window
-
/chatops run feature delete multiple_merge_request_assignees
-
/chatops run feature delete open_in_xcode
-
/chatops run feature delete operation_user_update_branch
-
/chatops run feature delete pages_auto_ssl
-
/chatops run feature delete pages_auto_ssl_for_project
-
/chatops run feature delete paginate_without_count
-
/chatops run feature delete parse_container_scanning_reports
-
/chatops run feature delete parse_dependency_scanning_reports
-
/chatops run feature delete pipeline_dashboard
-
/chatops run feature delete protected_branch_creation
-
/chatops run feature delete protected_environments
-
/chatops run feature delete releases_page
-
/chatops run feature delete remove_disabled_domains
-
/chatops run feature delete reply_to_individual_notes
-
/chatops run feature delete report_approver_rules
-
/chatops run feature delete shared_runner_minutes_on_root_namespace
-
/chatops run feature delete store_security_reports
-
/chatops run feature delete tablesample_counts
-
/chatops run feature delete tag_names
-
/chatops run feature delete update_all_mirrors_worker_rescheduling
-
/chatops run feature delete update_statistics_namespace
-
/chatops run feature delete use_cte_for_group_issues_search
-
/chatops run feature delete use_subquery_for_group_issues_search
-
/chatops run feature delete variable_masking
Previously included, but were false matches (still in code):
asset_host_prefetch
ci_disable_validates_dependencies
ci_pipeline_persisted_stages
enforced_group_managed_accounts
Also feature flags starting with prometheus_transaction_
as the are dynamically built. See https://gitlab.com/gitlab-org/gitlab-ee/issues/13567#note_204368521
How to clean up
Once you have verified that the FF was removed from codebase (and is live on GitLab.com), see https://docs.gitlab.com/ee/development/feature_flags/controls.html#cleaning-up for instructions
Edited by Douwe Maan