DB load balancing: Log when we use a different secondary host when there's a query conflict
We currently log that a host is offline in LoadBalancer#read
We should also log when we need to try a different host due to query conflicts (https://gitlab.com/gitlab-org/gitlab-ee/blob/4d73f53e7f5c5fdd1989ac2c71d51a6d40dbe3f0/ee/lib/gitlab/database/load_balancing/load_balancer.rb#L42-43)
Designs
- Show closed items
Relates to
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
- Thong Kuah added Observability database infradev labels
added Observability database infradev labels
- Thong Kuah added gitlab.com label
added gitlab.com label
- Dylan Griffith added backend label
added backend label
- Dylan Griffith changed milestone to %12.3
changed milestone to %12.3
- Dylan Griffith added devopsconfigure [DEPRECATED] groupconfigure [DEPRECATED] + 1 deleted label
added devopsconfigure [DEPRECATED] groupconfigure [DEPRECATED] + 1 deleted label
@DylanGriffith @tkuah Since this is a ~P1 can we please assign it to the individual currently working on this. Thank you!
1- Maintainer
Just for reference, I think we'll probably also want this new log to be json structured. So probably this issue is dependent on this decision to define if the log goes into a new file or to an existing one: https://gitlab.com/gitlab-org/gitlab-ee/issues/13547#note_205119424
If it's a new file, it might make sense to wait for #13547 (closed) to be resolved, so we can reuse the log class that will be created for it.
Collapse replies - Maintainer
@Alexand yeah it seems that this issue is dependent on https://gitlab.com/gitlab-org/gitlab-ee/issues/13547 . We should switch the log format to JSON then add this new type of logging.
- Maintainer
@hfyngvason since you're already working on https://gitlab.com/gitlab-org/gitlab-ee/issues/13547 I'm going to assign this to you as well.
As per https://gitlab.com/gitlab-org/gitlab-ce/issues/66074#note_204910246 if you are finding yourself spending more than 2 full focused days on these issues please update @danielgruesso and ask if he'd like us to continue.
- Thong Kuah marked this issue as related to #13630 (closed)
marked this issue as related to #13630 (closed)
- Thong Kuah removed the relation with #13630 (closed)
removed the relation with #13630 (closed)
- Thong Kuah marked this issue as related to #13547 (closed)
marked this issue as related to #13547 (closed)
- Dylan Griffith assigned to @hfyngvason
assigned to @hfyngvason
- Dylan Griffith added workflowin dev label and removed workflowready for development label
added workflowin dev label and removed workflowready for development label
- Hordur Freyr Yngvason mentioned in merge request !15442 (merged)
mentioned in merge request !15442 (merged)
- Hordur Freyr Yngvason added workflowin review label and removed workflowin dev label
added workflowin review label and removed workflowin dev label
- Dalia Havens assigned to @dhavens and unassigned @hfyngvason
assigned to @dhavens and unassigned @hfyngvason
- Dalia Havens assigned to @hfyngvason and unassigned @dhavens
assigned to @hfyngvason and unassigned @dhavens
- Daniel Gruesso removed 1 deleted label
removed 1 deleted label
The weekly Availability and Performance Grooming is tomorrow, this issue is on the board https://gitlab.com/groups/gitlab-org/-/boards/1193197?label_name[]=gitlab.com&label_name[]=infradev. Is it possible to provide an update of current state and what's next and ETA?
- Author Maintainer
@cdu1 This is in ~"workflow::In review" and the MR to resolve this https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/15442 is pending final review by maintainers. It should be merged by end of this week at latest, I expect
Edited by Thong Kuah - Maintainer
Closing this issue as gitlab-org/gitlab-ee!15442 is merged.
- Tim Zallmann closed
closed
- 🤖 GitLab Bot 🤖 added groupenvironments label and removed groupconfigure [DEPRECATED] label
added groupenvironments label and removed groupconfigure [DEPRECATED] label