Code-quality follow up

Summary

This is a follow up issue to https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/14656, to fix the code quality issues introduced there:

  • File index_spec.js has 315 lines of code (exceeds 250 allowed). Consider refactoring. in ee/spec/frontend/design_management/pages/design/index_spec.js:1

  • Function createComponent has 67 lines of code (exceeds 25 allowed). Consider refactoring. in ee/spec/frontend/design_management/pages/design/index_spec.js:67

  • Function modify has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. in ee/app/assets/javascripts/design_management/utils/design_management_utils.js:53

  • Method run has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. in ee/db/fixtures/development/27_designs.rb:54

  • Method run has 27 lines of code (exceeds 25 allowed). Consider refactoring. in ee/db/fixtures/development/27_designs.rb:54

  • Similar blocks of code found in 2 locations. Consider refactoring. in ee/spec/frontend/design_management/pages/design/index_spec.js:238,253

Improvements

This will make code-climate happy, which makes developers happy, which makes me happy.

Risks

None

Involved components

  • ee/spec/frontend/design_management/pages/design/index_spec.js:1
  • ee/spec/frontend/design_management/pages/design/index_spec.js:67
  • ee/app/assets/javascripts/design_management/utils/design_management_utils.js:53
  • ee/db/fixtures/development/27_designs.rb:54
  • ee/db/fixtures/development/27_designs.rb:54
  • ee/spec/frontend/design_management/pages/design/index_spec.js:238
  • ee/spec/frontend/design_management/pages/design/index_spec.js:253
Edited by Alex Kalderimis