Increasing the no. required approvals does not reflect in the MR listview
Summary
When updating the required number of approvals on a MR, it doesn't update in the listview and keeps showing the original number of required approvals.
Steps to reproduce
- Open an MR with e.g. 1 required approval (not sure if it matters that in my case it is the project default)
- Listview of MR's shows the MR with '0 of 1' approvals
- Edit the MR to increase the number of required approvals
- Listview still shows '0 of 1' while it should say e.g. '0 of 3'
What is the current bug behavior?
It stays on the initial number of required approvals
What is the expected correct behavior?
It should reflect the updated number of requried approvals
Relevant logs and/or screenshots
Output of checks
No idea if this happens on Gitlab.com.
Results of GitLab environment info
Expand for output related to GitLab environment info
System information System: Debian 8.11 Proxy: no Current User: git Using RVM: no Ruby Version: 2.6.3p62 Gem Version: 2.7.9 Bundler Version:1.17.3 Rake Version: 12.3.2 Redis Version: 3.2.12 Git Version: 2.21.0 Sidekiq Version:5.2.7 Go Version: unknown
GitLab information Version: 12.1.2-ee Revision: d7aa668babd Directory: /opt/gitlab/embedded/service/gitlab-rails DB Adapter: PostgreSQL DB Version: 10.7 URL: https://git.otainsight.com HTTP Clone URL: https://git.otainsight.com/some-group/some-project.git SSH Clone URL: git@git.otainsight.com:some-group/some-project.git Elasticsearch: yes Geo: no Using LDAP: no Using Omniauth: yes Omniauth Providers: google_oauth2, bitbucket
GitLab Shell Version: 9.3.0 Repository storage paths:
- default: /var/opt/gitlab/git-data/repositories GitLab Shell path: /opt/gitlab/embedded/service/gitlab-shell Git: /opt/gitlab/embedded/bin/git
Results of GitLab application Check
Expand for output related to the GitLab application check
Checking GitLab subtasks ...
Checking GitLab Shell ...
GitLab Shell: ... GitLab Shell version >= 9.3.0 ? ... OK (9.3.0) Running /opt/gitlab/embedded/service/gitlab-shell/bin/check Check GitLab API access: OK Redis available via internal API: OK
Access to /var/opt/gitlab/.ssh/authorized_keys: OK gitlab-shell self-check successful
Checking GitLab Shell ... Finished
Checking Gitaly ...
Gitaly: ... default ... OK
Checking Gitaly ... Finished
Checking Sidekiq ...
Sidekiq: ... Running? ... yes Number of Sidekiq processes ... 1
Checking Sidekiq ... Finished
Checking Incoming Email ...
Incoming Email: ... Reply by email is disabled in config/gitlab.yml
Checking Incoming Email ... Finished
Checking LDAP ...
LDAP: ... LDAP is disabled in config/gitlab.yml
Checking LDAP ... Finished
Checking GitLab App ...
Git configured correctly? ... yes Database config exists? ... yes All migrations up? ... yes Database contains orphaned GroupMembers? ... no GitLab config exists? ... yes GitLab config up to date? ... yes Log directory writable? ... yes Tmp directory writable? ... yes Uploads directory exists? ... yes Uploads directory has correct permissions? ... yes Uploads directory tmp has correct permissions? ... yes Init script exists? ... skipped (omnibus-gitlab has no init script) Init script up-to-date? ... skipped (omnibus-gitlab has no init script) Projects have namespace: ... 4/2 ... yes 4/3 ... yes 4/5 ... yes 4/7 ... yes 4/8 ... yes 4/9 ... yes 4/10 ... yes 4/11 ... yes 4/12 ... yes 4/13 ... yes 4/14 ... yes 4/15 ... yes 4/16 ... yes 4/17 ... yes 4/18 ... yes 4/19 ... yes 4/20 ... yes 4/21 ... yes 4/22 ... yes 4/23 ... yes 4/24 ... yes 4/25 ... yes 4/26 ... yes 4/28 ... yes 4/29 ... yes 4/30 ... yes 4/32 ... yes 4/36 ... yes 4/38 ... yes 16/39 ... yes 4/40 ... yes 4/42 ... yes 4/43 ... yes 4/44 ... yes 4/45 ... yes 4/47 ... yes 4/48 ... yes 4/49 ... yes 4/50 ... yes 4/51 ... yes 4/52 ... yes 4/53 ... yes 4/54 ... yes 4/55 ... yes 4/56 ... yes 4/60 ... yes 4/63 ... yes 4/64 ... yes 4/65 ... yes 4/68 ... yes 4/69 ... yes 4/70 ... yes 4/71 ... yes 4/72 ... yes 50/73 ... yes 4/74 ... yes 59/76 ... yes 59/77 ... yes 59/78 ... yes 59/79 ... yes 60/80 ... yes 4/81 ... yes 4/82 ... yes 4/83 ... yes 4/84 ... yes 4/85 ... yes 4/86 ... yes 4/87 ... yes 61/88 ... yes 4/89 ... yes 4/90 ... yes 4/91 ... yes 4/93 ... yes 4/94 ... yes 4/95 ... yes Redis version >= 2.8.0? ... yes Ruby version >= 2.5.3 ? ... yes (2.6.3) Git version >= 2.21.0 ? ... yes (2.21.0) Git user has default SSH configuration? ... no Try fixing it: mkdir ~/gitlab-check-backup-1564992856 sudo mv /var/opt/gitlab/.ssh/id_rsa.pub ~/gitlab-check-backup-1564992856 sudo mv /var/opt/gitlab/.ssh/id_rsa ~/gitlab-check-backup-1564992856 For more information see: doc/ssh/README.md in section "SSH on the GitLab server" Please fix the error above and rerun the checks. Active users: ... 25 Elasticsearch version 5.6 - 6.x? ... yes (5.6.8)
Checking GitLab App ... Finished
Checking GitLab subtasks ... Finished
Possible fixes
(If you can, link to the line of code that might be responsible for the problem)