Design view: Allow comment pins on designs to be resolvable.
Problem to solve
When you receive lots of feedback on a Design, the number of comment pins can build up quickly! As your discussion thread grows, it gets hard to know which discussions are complete and which still need work.
With this feature you’ll have the ability to mark any comment as “Resolved” to signify that it is now complete. Even better — resolved comment pins will disappear from the Design so you can focus on what’s left. And if you need to revisit something, all your completed discussions will be availabled in the “Resolved Comment” area at the bottom of the sidebar. From there, you can find them again and see which revision applied at the point of revision.
We think this will greatly improve your workflow so you can focus on what is relevant to the current feedback.
Further details
The backend will need to implement two new GraphQL mutations:
resolveDiscussionunresolveDiscussion
Note, there is no service to unresolve discussions, however there are multiple places in the GitLab codebase that call discussion.unresolve! directly without a service. I believe we should do the same within our unresolve mutation, rather than to create a service now.
The frontend will need to implement the ability to resolve an annotation.
Proposal from @mnearents
- Figma Prototype 1: Resolving & unresolving via icon click
- Figma Prototype 2: Resolving & unresolving via comment
- See designs tab