Wording for "Allowed to push" dropdown is confusing

Resources

Problem

In EE we allow specific people to be selected for the "Allowed to push" setting of protected branches. This can lead to confusion when you select both "No one" and a specific user:

Pop quiz: which setting gets precedent here?

Answer: Both! One applies to role, the other applies to a specific user.

I think the setting should probably say "No roles" or something like that.

This is only unclear in EE but the setting should change in CE as well for consistency.

cc @cperessini

Solution

We break down the options into sections: "Roles", "Groups" and "Users". We also remove the "No one" option, since deselecting all options in the "Roles" section has the same effect.

EE

EE users can select roles as well as groups and individual users

CE

CE users can only select roles