Create an issue to resolve... button in MR does not link to JIRA

Summary

When a merge request has unresolved discussions and the merge criteria require discussions to be resolved, the UI displays a disabled Merge button followed by There are unresolved discussions. Please resolve these discussions along with a handy Create an issue to resolve them later button. Choosing that button takes you to a nicely pre-filled New Issue form in the local gitlab issue tracker for the project, even when JIRA integration is enabled. With JIRA integration, that button should not take you to the gitlab issue tracker, as that will create a lot of confusion for developers.

Steps to reproduce

  1. Create a project and integrate it with a JIRA instance.
  2. Configure the project by going to Settings > General > Merge requests and choosing Only allow merge requests to be merged if all discussions are resolved and Save changes.
  3. Open a merge request in the project.
  4. Start a discussion in the merge request.
  5. Observe that the MR shows There are unresolved discussions. Please resolve these discussions along with a handy Create an issue to resolve them later button.
  6. Choose the Create an issue to resolve them later button.

What is the current bug behavior?

Choosing that button takes you to a New Issue form in the local gitlab issue tracker for the project, not JIRA.

What is the expected correct behavior?

With JIRA integration, that button should not take you to the gitlab issue tracker, as that will create a lot of confusion for developers. Possible correct behaviors:

  • The button takes you to the new issue form in the JIRA issue tracker.
  • The button is not displayed.

Relevant logs and/or screenshots

Screenshot_from_2019-07-17_10-42-01

Output of checks

Results of GitLab environment info

Expand for output related to GitLab environment info 
System information
System:		Ubuntu 16.04
Proxy:		no
Current User:	git
Using RVM:	no
Ruby Version:	2.5.3p105
Gem Version:	2.7.6
Bundler Version:1.17.3
Rake Version:	12.3.2
Redis Version:	3.2.12
Git Version:	2.18.1
Sidekiq Version:5.2.5
Go Version:	unknown


GitLab information
Version:	11.10.1-ee
Revision:	2cd7cedf96c
Directory:	/opt/gitlab/embedded/service/gitlab-rails
DB Adapter:	PostgreSQL
DB Version:	9.6.11
URL:		http://gitlab3.eng.local
HTTP Clone URL:	http://gitlab3.eng.local/some-group/some-project.git
SSH Clone URL:	git@gitlab3.eng.local:some-group/some-project.git
Elasticsearch:	no
Geo:		no
Using LDAP:	no
Using Omniauth:	yes
Omniauth Providers:


GitLab Shell
Version:	9.0.0
Repository storage paths:
  • default: /var/opt/gitlab/git-data/repositories GitLab Shell path: /opt/gitlab/embedded/service/gitlab-shell Git: /opt/gitlab/embedded/bin/git

Results of GitLab application Check

Expand for output related to the GitLab application check 
Checking GitLab subtasks ...


Checking GitLab Shell ...


GitLab Shell: ... GitLab Shell version >= 9.0.0 ? ... OK (9.0.0)
Running /opt/gitlab/embedded/service/gitlab-shell/bin/check
Check GitLab API access: OK
Redis available via internal API: OK


Access to /var/opt/gitlab/.ssh/authorized_keys: OK
gitlab-shell self-check successful


Checking GitLab Shell ... Finished


Checking Gitaly ...


Gitaly: ... default ... OK


Checking Gitaly ... Finished


Checking Sidekiq ...


Sidekiq: ... Running? ... yes
Number of Sidekiq processes ... 1


Checking Sidekiq ... Finished


Checking Incoming Email ...


Incoming Email: ... Reply by email is disabled in config/gitlab.yml


Checking Incoming Email ... Finished


Checking LDAP ...


LDAP: ... LDAP is disabled in config/gitlab.yml


Checking LDAP ... Finished


Checking GitLab App ...


Git configured correctly? ... yes
Database config exists? ... yes
All migrations up? ... yes
Database contains orphaned GroupMembers? ... no
GitLab config exists? ... yes
GitLab config up to date? ... yes
Log directory writable? ... yes
Tmp directory writable? ... yes
Uploads directory exists? ... yes
Uploads directory has correct permissions? ... yes
Uploads directory tmp has correct permissions? ... yes
Init script exists? ... skipped (omnibus-gitlab has no init script)
Init script up-to-date? ... skipped (omnibus-gitlab has no init script)
Projects have namespace: ...
1/1 ... yes
2/2 ... yes
2/3 ... yes
10/4 ... yes
11/5 ... yes
2/6 ... yes
10/8 ... yes
3/9 ... yes
4/10 ... yes
9/11 ... yes
9/12 ... yes
2/13 ... yes
13/14 ... yes
6/15 ... yes
Redis version >= 2.8.0? ... yes
Ruby version >= 2.5.3 ? ... yes (2.5.3)
Git version >= 2.18.0 ? ... yes (2.18.1)
Git user has default SSH configuration? ... yes
Active users: ... 11
Elasticsearch version 5.6 - 6.x? ... skipped (elasticsearch is disabled)


Checking GitLab App ... Finished


Checking GitLab subtasks ... Finished