View people who have approved merge request
Resources
PM @victorwu | UX @hazelyang
Description
- We want to support the unapprove merge request feature (#894 (closed)). The first step is to re-design the existing approvals interface to support #894 (closed) to and allow future (#761) to be created with a clean design.
- The net new functionality for this issue is viewing who has already approved a merge request. (This does not currently exist.)
- This merge request for this issue should only contain this issue and no other scope.
Out of scope
- Removing an approval is not part of this issue.
Design and mockups
- View who has already approved a merge request with the profile pictures with checkmark icon in the top-right corner.
- Tooltip on the profile icons and link to those people, similar to the sidebar.
- View how many remaining approvals are required with the dotted circles.
![](/-/project/278964/uploads/c539c4a5e0ded7201617dad2d945608f/Screen_Shot_2016-11-18_at_9.02.41_AM.png)
![](/-/project/278964/uploads/1ff50042f3bf44d5fc929355559dcb25/Screen_Shot_2016-11-18_at_9.02.49_AM.png)
![](/-/project/278964/uploads/020374ffd579cc1adb3bd3f1f5229d97/Screen_Shot_2016-11-18_at_9.03.00_AM.png)
Edited by Coung Ngo