Skip to content
GitLab
Next
    • GitLab: the DevOps platform
    • Explore GitLab
    • Install GitLab
    • How GitLab compares
    • Get started
    • GitLab docs
    • GitLab Learn
  • Pricing
  • Talk to an expert
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    Projects Groups Topics Snippets
  • Register
  • Sign in
  • GitLab GitLab
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Issues 50,597
    • Issues 50,597
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 1,553
    • Merge requests 1,553
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
    • Test cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.orgGitLab.org
  • GitLabGitLab
  • Issues
  • #12420
Closed
Open
Issue created Jun 26, 2019 by Jeremy Watson (ex-GitLab)@jeremy-glContributor

Prevent projects from being shared outside a GMA group

Problem

When enforcing SSO and group-managed accounts, the desired experience is to require SSO for access to any projects and subgroups within a top-level group.

However, it's currently possible to share a project within a group enforcing SSO with a group outside of the top-level group's namespace - or by adding members outside the group directly to a project. While this has to be initiated by the group's Owner, this edge case has the potential to effectively subvert SSO enforcement.

Proposal

  • When SSO enforcement is enabled for a group, present an error if:
    • A user attempts to share a project in the group outside the top-level group.
    • A user attempts to add members to the project who are not members of the group enforcing GMA.
  • This should apply to projects in the GMA group, as well as projects forked from those projects.
  • Sharing projects with subgroups within the top level group should be possible.

"GMA" here refers to Group Managed Accounts.

Availability & Testing

What risks does this change pose to our availability?

  • Any existing access of groups outside the top level GMA group shared with a project in a GMA group gets revoked. (Would this be intentional/expected behaviour?)
  • For forked projects, any existing access of groups outside the top level GMA group shared with the forked project in a GMA group gets revoked.
  • The restriction is applied to SSO enabled groups that do not have GMA enabled.
  • Share with group lock functionality breaks and allows sharing with groups with the same top-level group.

What additional test coverage or changes to tests will be needed?

Tests and at unit and feature level should provide enough coverage. New End-to-end tests should not be required however, we should run the package-and-qa job before merging to ensure current tests are fine.

Edited Feb 10, 2020 by Sanad Liaquat
Assignee
Assign to
Time tracking