Code Quality no 'Download' option and 'Keep' results in 404

Summary

When using artifacts:reports:codequality the resulting job has no ability to download the report and due to gitlab-org/gitlab-ee#4189 there is no way to view it. There is a 'Keep' button but clicking this results in a 404.

Screenshot_2019-06-19_at_09.37.52

Steps to reproduce

  1. Use the Jobs/Code-Quality.gitlab-ci.yml job within a pipeline. This has artifacts:reports:codequality set.
  2. Run pipeline,
  3. Navigate to the code_quality job and observe right hand panel.

Example Project

N/A

What is the current bug behavior?

Not possible to view or download code quality report.

What is the expected correct behavior?

View or download code quality report.

Relevant logs and/or screenshots

N/A

Proposal

Going forward the Keep button will not be necessary after completion of #16267 (closed) and so will be removed.

The Download button will now download the codeclimate generated code climate report will then be available until the expire_in has passed and the download button should be made inactive.

Another issue was opened to improve the experience when no buttons are present but the job created one.

Output of checks

This bug happens on GitLab.com

Edited by James Heimbuck