Follow-up from "Fix group usage quota menu item"
The following discussion from !14043 (merged) should be addressed:
-
@mayra-cabrera started a discussion: (+5 comments) Could we please add a feature spec to ensure this does not happen again?
This is a good observation because I was sure we had tests for this in
ee/spec/features/groups/usage_quotas_spec.rb
But writing a test for this specific issue means writing something that stub out:audit_events
for testing Usage quotas, I don't think it makes any sense. So the real problem here is that this feature doesn't act as CE when unlicensed. Should we add a:usage_quotas
feature to GitLab Starter license and enforce it at routes and menu level?This makes a lot of sense from a developer perspective. I wonder if we need to double check with someone before making this move. Maybe @marin or @trizzi can help?
I think that usage quotas are such a core functionality that is should be in all editions, but this is a Product call so @trizzi and @jeremy might need to make a call.
This is what I suggested during the initial development, but porting that page from EE to CE was out of scope, so in this MR it became a GitLab Starter feature, so that it's available on all the EE license tiers but we can still act as CE when unlicensed
Since we're not changing the actual behavior, I'm going to merge as-is and open a follow up issue to discuss what kind of license should be given to usage quotas