Geo: Trailing / missing from secondary Name in geo admin area causes Not a secondary node

Summary

When setting up the Name of a secondary node in the admin area of the primary, the trailing / is necessary. When it is missing, gitlab-rake gitlab:geo:check returns not a secondary node. The trailing / is necessary even when it is not included in the external_url of the secondary node.

Steps to reproduce

  1. Navigate to the Geo admin area on the primary (/admin/geo/nodes).
  2. Add or edit a secondary node.
  3. Set the Name without the trailing / (i.e.https://geo-secondary.example.com)
  4. Run gitlab-rake gitlab:geo:check on the secondary and see not a secondary node
  5. Adding the trailing / will make the check pass.

What is the current bug behavior?

A trailing / is needed in the Name of the secondary node in the primary Geo admin area. Even when it is not included in the external_url of the secondary.

What is the expected correct behavior?

The trailing / should not be needed. Especially when it is not included in external_url

Noticed on 11.11.x

Assignee Loading
Time tracking Loading