Edit button in the diff when creating a new merge request is blue with gray text.

Summary

When you are creating a merge request, if you look at your code in the diff view, you'll notice that the Edit button is blue with gray text. I think it's supposed to have a white background color and turn blue on hover/active. Or it's supposed to be blue with white text.

Steps to reproduce

  • Create a new branch
  • Commit some code changes (anything to produce a diff)
  • Create a new merge request on GitLab
  • While creating the new merge request, go to the diff view.
  • You'll see an Edit button on your diff, but either the background color or the font color is incorrect.

What is the current bug behavior?

Either the background color or the font color is incorrect on the Edit button on the diff view. It's low contrast and which decreases legibility.

What is the expected correct behavior?

The button should have higher contrast. I think it's supposed to have a white background color and turn blue on hover/active. Or it's supposed to be blue as it is, but with white text color.

Relevant logs and/or screenshots

image

Output of checks

This bug happens on GitLab.com

Results of GitLab environment info

Expand for output related to GitLab environment info 
(For installations with omnibus-gitlab package run and paste the output of:
sudo gitlab-rake gitlab:env:info)


(For installations from source run and paste the output of:
sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production)

Results of GitLab application Check

Expand for output related to the GitLab application check 
(For installations with omnibus-gitlab package run and paste the output of:
sudo gitlab-rake gitlab:check SANITIZE=true)


(For installations from source run and paste the output of:
sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true)


(we will only investigate if the tests are passing)

Possible fixes

Not sure, but the button classes come from btn btn-primary js-edit-blob

However, it is also inheriting the gray color from .diff-file .file-title-flex-parent a