Follow-up from "Improve add cluster documentation"
The following discussions from !21806 (merged) should be addressed:
-
@marcel.amirault started a discussion: (+3 comments) Not sure what this line is trying to say...
-
@marcel.amirault started a discussion: (+2 comments) This line is also confusing, as it's the first time we're talking about selecting a cluster. Can this
## cluster precedence
section be cleared up somehow? -
@marcel.amirault started a discussion: (+1 comment) Since we are here, I think we should change the grammar:
set up an [initial service account](#access-controls). Since [GitLab 11.10](https://gitlab.com/gitlab-org/gitlab-foss/issues/58208), the cluster creation process explicitly requires that basic authentication and client certificate is enabled.
-
@marcel.amirault started a discussion: (+1 comment) @eread I did my first review with a variety of suggestions. Any you feel are out of scope can be passed on to a separate issue if you like, but i tried to stay on topic as much as I could.
I have one major suggestion I needed to add here. I found that the structure itself was confusing, with EKS and GKE information mixed together:
To me it would make more sense to keep the EKS and GKE stuff grouped together, not grouping it by whether or not it's new or existing.
So (simplified, just to illustrate):
- Add GKE Cluster
- Add new GKE cluster
- Add existing GKE cluster
- Add EKS Cluster
- Add new EKS cluster
- Add existing EKS cluster
WDYT?
- Add GKE Cluster