MIgration failure in 20190114040405_consume_remaining_migrate_approver_to_approval_rules_in_batch_jobs.rb
Caught by the omnibus-upgrade
job in the nightly pipeline: https://gitlab.com/gitlab-org/quality/nightly/-/jobs/224577641
PG::UndefinedColumn: ERROR: column approval_merge_request_rules.rule_type does not exist
LINE 1: ...l_merge_request_rules"."merge_request_id" = 1 AND "approval_...
^
: DELETE FROM "approval_merge_request_rules" WHERE "approval_merge_request_rules"."merge_request_id" = 1 AND "approval_merge_request_rules"."rule_type" = 'code_owner'
/opt/gitlab/embedded/service/gitlab-rails/config/initializers/peek.rb:18:in `async_exec_params'
/opt/gitlab/embedded/service/gitlab-rails/config/initializers/peek.rb:18:in `exec_params'
/opt/gitlab/embedded/service/gitlab-rails/ee/app/models/ee/merge_request.rb:188:in `sync_code_owners_with_approvers'
/opt/gitlab/embedded/service/gitlab-rails/ee/lib/gitlab/background_migration/migrate_approver_to_approval_rules.rb:76:in `block in sync_code_owners_with_approvers'
/opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/gitaly_client.rb:305:in `allow_n_plus_1_calls'
/opt/gitlab/embedded/service/gitlab-rails/ee/lib/gitlab/background_migration/migrate_approver_to_approval_rules.rb:75:in `sync_code_owners_with_approvers'
/opt/gitlab/embedded/service/gitlab-rails/ee/lib/gitlab/background_migration/migrate_approver_to_approval_rules.rb:131:in `handle_merge_request'
/opt/gitlab/embedded/service/gitlab-rails/ee/lib/gitlab/background_migration/migrate_approver_to_approval_rules.rb:117:in `block in perform'
/opt/gitlab/embedded/service/gitlab-rails/ee/lib/gitlab/background_migration/migrate_approver_to_approval_rules.rb:114:in `perform'
/opt/gitlab/embedded/service/gitlab-rails/ee/lib/gitlab/background_migration/migrate_approver_to_approval_rules_in_batch.rb:13:in `block in perform'
/opt/gitlab/embedded/service/gitlab-rails/ee/lib/gitlab/background_migration/migrate_approver_to_approval_rules_in_batch.rb:12:in `each'
/opt/gitlab/embedded/service/gitlab-rails/ee/lib/gitlab/background_migration/migrate_approver_to_approval_rules_in_batch.rb:12:in `perform'
/opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/background_migration.rb:58:in `perform'
/opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/background_migration.rb:38:in `block (2 levels) in steal'
/opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/background_migration.rb:31:in `block in steal'
/opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/background_migration.rb:30:in `each'
/opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/background_migration.rb:30:in `steal'
/opt/gitlab/embedded/service/gitlab-rails/ee/db/migrate/20190114040405_consume_remaining_migrate_approver_to_approval_rules_in_batch_jobs.rb:40:in `up'
/opt/gitlab/embedded/service/gitlab-rails/lib/tasks/gitlab/db.rake:56:in `block (3 levels) in <top (required)>'
/opt/gitlab/embedded/bin/bundle:23:in `load'
/opt/gitlab/embedded/bin/bundle:23:in `<main>'
/cc @lulalala