Formal merge request disapproval

Problem to solve

Merge requests can be formally approved, but there is no formal process to disapprove a merge request.

Intended users

Developers

Further details

Merge Requests have "thumbs up" and "thumbs down" emojis but these are not formal approvals and disapprovals: they do not get reset on new commits coming into the merge request and there can be many other emojis added to the merge request.

Formal disapproval is a key feature because there are times where you want to clearly indicate that you wish to block the merging of a merge request.

Proposal

Have a new button for "Disapprove" in addition to the current "Approve" button. Approvals and disapprovals should be reset on new commits coming into the merge request.

There should also be support per-project to not allow merging if there are more than a certain number of disapprovals.

Permissions and Security

No major changes to security or permissions.

Documentation

Documentation would need to be created.

Testing

Ensuring that disapprovals are reset on new commits coming into the merge request.

What does success look like, and how can we measure that?

Ability to formally disapprove merge requests and support configuration to not allow merging if there are more than a certain number of disapprovals.

What is the type of buyer?

Bronze

Links / references