New admin license page shows free guest tooltip when plan is not Ultimate

Summary

When on a non-Ultimate plan, "seats currently in use" tooltip on the license page shows the "free guests" tooltip:

Screenshot_2019-05-28_at_11.22.57_AM

This happens on v11.10.x-ee.

Steps to reproduce

  1. Have a non-Ultimate license

Example Project

N/A

What is the current bug behavior?

When on a non-Ultimate plan, "seats currently in use" tooltip on the license page shows the "free guests" tooltip.

What is the expected correct behavior?

When on a non-Ultimate plan, "seats currently in use" tooltip on the license page should not show the "free guests" tooltip.

Relevant logs and/or screenshots

(Paste any relevant logs - please use code blocks (```) to format console output, logs, and code as it's tough to read otherwise.)

Output of checks

(If you are reporting a bug on GitLab.com, write: This bug happens on GitLab.com)

Results of GitLab environment info

Expand for output related to GitLab environment info

(For installations with omnibus-gitlab package run and paste the output of: sudo gitlab-rake gitlab:env:info)

(For installations from source run and paste the output of: sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production)

Results of GitLab application Check

Expand for output related to the GitLab application check

(For installations with omnibus-gitlab package run and paste the output of: sudo gitlab-rake gitlab:check SANITIZE=true)

(For installations from source run and paste the output of: sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true)

(we will only investigate if the tests are passing)

Possible fixes

https://gitlab.com/gitlab-org/gitlab-ee/blob/master/ee/app/assets/javascripts/licenses/components/cards/license_card_body.vue#L74

This line showing the popover needs to be conditional on the license plan.

Edited May 28, 2019 by Wei-Meng Lee
Assignee Loading
Time tracking Loading