Follow-up on Epic Tree app
Summary
In %12.0, we're replacing Epics list and Issues list on Epic page with a Tree
tab that shows Epics and Issues combined in a tree structure (via https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/10999), given the size of feature, there are several small changes suggested in the app as follows;
- Make Epic/Issue count in tree header include child items as nodes are expanded/collapsed. - Done in https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/14003
-
Handling pagination.Moved to https://gitlab.com/gitlab-org/gitlab-ee/issues/11971. -
Explore a way to useApolloCache
for data caching instead of storing everything to Vuex store.- We're skipping this for now since having all the nodes data present within Vuex store itself makes it much easier to deal with item removals (we show a modal containing parent and child info during item removal). Using
ApolloCache
would mean that we discard all that info in favour of ApolloClient's caching.
- We're skipping this for now since having all the nodes data present within Vuex store itself makes it much easier to deal with item removals (we show a modal containing parent and child info during item removal). Using
-
Use fragments inDone in !14083 (merged).ee/app/assets/javascripts/related_items_tree/queries/child_items.graphql
for common properties. -
FixDone in https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/14113selector-max-compound-selectors
warnings onee/app/assets/stylesheets/components/related_items_tree.scss
.
Edited by Kushal Pandya