Group SAML setting toggles have no effect
Summary
Follow up from https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/10338#note_168523896 After latest master rebase SSO toggles on group SAML settings page stopped to work.
Steps to reproduce
Setup GDK according to https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/10338
Setup GDK
- Make sure you have an
Ultimate
license for your local instance. - Enable the following feature flags via the Rails console (run
rails c
ingdk-ee/gitlab
):- sign_up_on_sso
- enforced_sso
- group_managed_accounts
- DO NOT enable :group_scim flag
- Follow gdk saml docs, adding he following changes to your
gitlab.yaml
file:
omniauth:
providers:
- { name: 'group_saml' }
-
Enable SAML Single Sign On for one of your groups (e.g.,
gitlab-org
):- Go to your group ->
Settings
->SAML SSO
- Go to your group ->
-
Try to use the toggles
Example Project
(If possible, please create an example project here on GitLab.com that exhibits the problematic behaviour, and link to it here in the bug report)
(If you are using an older version of GitLab, this will also determine whether the bug has been fixed in a more recent version)
What is the current bug behavior?
Toggles have no effect. No visual changes when you click on them.
What is the expected correct behavior?
Toggles should toggle when you click on them.
Relevant logs and/or screenshots
Investigation
Seems like SCIMTokenToggleArea
relies on the fact that http://gitlab.com/gitlab-org/gitlab-ee/blob/5292-new-user-flow-for-group-managed-accounts/ee/app/views/groups/saml_providers/show.html.haml#L14-14 is enabled. Page gets broken if the flag is not enabled. There are lots of other functionality on the page besides SCIM token