"command not found" during checking CI cache
Summary
Since I upgraded to GitLab 8.13, CI builds have been failing to check CI caches.
Steps to reproduce
Run a build on GitLab 8.13.0-ee.
Expected behavior
Getting CI cache successfully.
Actual behavior
Failing because it executes a part of querystring as a command.
Relevant logs and/or screenshots
I blinded something can be sensitive:
if "/usr/bin/gitlab-runner-helper" cache-extractor --file ../../../cache/sub/xxxxxx/test/develop/cache.zip --url https://s3-ap-northeast-1.amazonaws.com/ci-cache.xxxxxx/runner/xxxxxxxx/project/1/test/develop?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=xxxxxxxxxxxxxxxxxxxx%2F20161024%2Fap-northeast-1%2Fs3%2Faws4_request&X-Amz-Date=20161024T043409Z&X-Amz-Expires=1800&X-Amz-SignedHeaders=host&X-Amz-Signature=xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx >/dev/null 2>/dev/null; then
echo $'\''\x1b[32;1mSuccessfully extracted cache\x1b[0;m'\''
else
echo $'\''\x1b[0;1mFailed to extract cache\x1b[0;m'\''
fi
Checking cache for test/develop...
++ ++ X-Amz-Credential=xxxxxxxxxxxxxxxxxxxx%2F20161024%2Fap-northeast-1%2Fs3%2Faws4_request
++ X-Amz-Signature=xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
/bin/bash: line 73: X-Amz-Credential=xxxxxxxxxxxxxxxxxxxx%2F20161024%2Fap-northeast-1%2Fs3%2Faws4_request: command not found
/usr/bin/gitlab-runner-helper cache-extractor --file ../../../cache/sub/xxxxxx/test/develop/cache.zip --url 'https://s3-ap-northeast-1.amazonaws.com/ci-cache.xxxxxx/runner/xxxxxxxx/project/1/test/develop?X-Amz-Algorithm=AWS4-HMAC-SHA256'
++ ++ ++ X-Amz-Date=20161024T043409ZX-Amz-Expires=1800
X-Amz-Credential=xxxxxxxxxxxxxxxxxxxx%2F20161024%2Fap-northeast-1%2Fs3%2Faws4_request is a part of querystring to get CI cache from S3. But GitLab CI treats it as a command.
Output of checks
Results of GitLab application Check
Too long to paste but all passed.
Results of GitLab environment info
I blinded the URL:
System information
System: Ubuntu 14.04
Current User: git
Using RVM: no
Ruby Version: 2.3.1p112
Gem Version: 2.6.6
Bundler Version:1.13.5
Rake Version: 10.5.0
Sidekiq Version:4.2.1
GitLab information
Version: 8.13.0-ee
Revision: 562bbc6
Directory: /opt/gitlab/embedded/service/gitlab-rails
DB Adapter: PostgreSQL
DB Version: 9.2.18
URL: http://xxx
HTTP Clone URL: http://xxx/some-group/some-project.git
SSH Clone URL: git@xxx:some-group/some-project.git
Elasticsearch: no
Geo: no
Using LDAP: no
Using Omniauth: no
GitLab Shell
Version: 3.6.6
Repository storage paths:
- default: /var/opt/gitlab/git-data/repositories
Hooks: /opt/gitlab/embedded/service/gitlab-shell/hooks/
Git: /opt/gitlab/embedded/bin/git