Comments on personal snippets fail to be indexed to Elasticsearch
Summary
Comments on personal snippets fail to be indexed to Elasticsearch.
Steps to reproduce
-
Create a comment on a personal snippet. Let's say the ID of the Note object is 7.
-
In Rails console:
ElasticIndexerWorker.new.perform('index', 'Note', 7, nil)
- Output:
Traceback (most recent call last):
16: from bin/rails:4:in `<main>'
15: from bin/rails:4:in `require'
14: from /opt/gitlab/embedded/lib/ruby/gems/2.5.0/gems/railties-5.0.7.2/lib/rails/commands.rb:18:in `<top (required)>'
13: from /opt/gitlab/embedded/lib/ruby/gems/2.5.0/gems/railties-5.0.7.2/lib/rails/commands/commands_tasks.rb:49:in `run_command!'
12: from /opt/gitlab/embedded/lib/ruby/gems/2.5.0/gems/railties-5.0.7.2/lib/rails/commands/commands_tasks.rb:78:in `console'
11: from /opt/gitlab/embedded/lib/ruby/gems/2.5.0/gems/railties-5.0.7.2/lib/rails/commands/console_helper.rb:9:in `start'
10: from /opt/gitlab/embedded/lib/ruby/gems/2.5.0/gems/railties-5.0.7.2/lib/rails/commands/console.rb:65:in `start'
9: from (irb):38
8: from /opt/gitlab/embedded/service/gitlab-rails/ee/app/workers/elastic_indexer_worker.rb:20:in `perform'
7: from /opt/gitlab/embedded/service/gitlab-rails/ee/app/workers/elastic_indexer_worker.rb:78:in `import'
6: from /opt/gitlab/embedded/service/gitlab-rails/ee/lib/gem_extensions/elasticsearch/model/indexing/instance_methods.rb:11:in `index_document'
5: from /opt/gitlab/embedded/lib/ruby/gems/2.5.0/gems/elasticsearch-api-5.0.3/lib/elasticsearch/api/actions/index.rb:100:in `index'
4: from /opt/gitlab/embedded/lib/ruby/gems/2.5.0/gems/elasticsearch-transport-5.0.3/lib/elasticsearch/transport/client.rb:131:in `perform_request'
3: from /opt/gitlab/embedded/lib/ruby/gems/2.5.0/gems/elasticsearch-transport-5.0.3/lib/elasticsearch/transport/transport/http/faraday.rb:20:in `perform_request'
2: from /opt/gitlab/embedded/lib/ruby/gems/2.5.0/gems/elasticsearch-transport-5.0.3/lib/elasticsearch/transport/transport/base.rb:318:in `perform_request'
1: from /opt/gitlab/embedded/lib/ruby/gems/2.5.0/gems/elasticsearch-transport-5.0.3/lib/elasticsearch/transport/transport/base.rb:201:in `__raise_transport_error'
Elasticsearch::Transport::Transport::Errors::BadRequest ([400] {"error":{"root_cause":[{"type":"mapper_parsing_exception","reason":"failed to parse"}],"type":"mapper_parsing_exception","reason":"failed to parse","caused_by":{"type":"illegal_argument_exception","reason":"[parent] is missing for join field [join_field]"}},"status":400})
What is the current bug behavior?
irb(main):039:0> Note.find(7).as_indexed_json
=> {"id"=>7, "note"=>":thinking: Sad", "project_id"=>nil, "noteable_type"=>"Snippet", "noteable_id"=>2, "created_at"=>Fri, 26 Apr 2019 03:33:05 UTC +00:00, "updated_at"=>Fri, 26 Apr 2019 03:33:05 UTC +00:00, "join_field"=>{"name"=>"note", "parent"=>nil}, "type"=>"note"}
This is caused by es_parent
being nil
as there is not project_id
associated with a PersonalSnippet comment.
What is the expected correct behavior?
I'm guessing the join_field
should look more like this:
"join_field": {
"name": "note",
"parent": "personal_snippet_1"
}
Output of checks
Results of GitLab environment info
Expand for output related to GitLab environment info
System information System: Debian 8.11 Proxy: no Current User: git Using RVM: no Ruby Version: 2.5.3p105 Gem Version: 2.7.6 Bundler Version:1.17.3 Rake Version: 12.3.2 Redis Version: 3.2.12 Git Version: 2.18.1 Sidekiq Version:5.2.5 Go Version: unknown
GitLab information Version: 11.10.1-ee Revision: 2cd7cedf96c Directory: /opt/gitlab/embedded/service/gitlab-rails DB Adapter: PostgreSQL DB Version: 9.6.11 URL: https://gitlab.weimeng.dev HTTP Clone URL: https://gitlab.weimeng.dev/some-group/some-project.git SSH Clone URL: git@gitlab.weimeng.dev:some-group/some-project.git Elasticsearch: yes Geo: no Using LDAP: no Using Omniauth: yes Omniauth Providers:
GitLab Shell Version: 9.0.0 Repository storage paths:
- default: /var/opt/gitlab/git-data/repositories GitLab Shell path: /opt/gitlab/embedded/service/gitlab-shell Git: /opt/gitlab/embedded/bin/git
Results of GitLab application Check
Expand for output related to the GitLab application check
Checking GitLab subtasks ...
Checking GitLab Shell ...
GitLab Shell: ... GitLab Shell version >= 9.0.0 ? ... OK (9.0.0) Running /opt/gitlab/embedded/service/gitlab-shell/bin/check Check GitLab API access: OK Redis available via internal API: OK
Access to /var/opt/gitlab/.ssh/authorized_keys: OK gitlab-shell self-check successful
Checking GitLab Shell ... Finished
Checking Gitaly ...
Gitaly: ... default ... OK
Checking Gitaly ... Finished
Checking Sidekiq ...
Sidekiq: ... Running? ... yes Number of Sidekiq processes ... 3 Try fixing it: sudo service gitlab stop sudo pkill -u git -f sidekiq sleep 10 && sudo pkill -9 -u git -f sidekiq sudo service gitlab start Please fix the error above and rerun the checks.
Checking Sidekiq ... Finished
Checking Incoming Email ...
Incoming Email: ... Reply by email is disabled in config/gitlab.yml
Checking Incoming Email ... Finished
Checking LDAP ...
LDAP: ... LDAP is disabled in config/gitlab.yml
Checking LDAP ... Finished
Checking GitLab App ...
Git configured correctly? ... yes Database config exists? ... yes All migrations up? ... yes Database contains orphaned GroupMembers? ... no GitLab config exists? ... yes GitLab config up to date? ... yes Log directory writable? ... yes Tmp directory writable? ... yes Uploads directory exists? ... yes Uploads directory has correct permissions? ... yes Uploads directory tmp has correct permissions? ... yes Init script exists? ... skipped (omnibus-gitlab has no init script) Init script up-to-date? ... skipped (omnibus-gitlab has no init script) Projects have namespace: ... 2/1 ... yes 2/2 ... yes 2/3 ... yes 4/4 ... yes 8/5 ... yes 8/6 ... yes 8/7 ... yes 8/8 ... yes 8/9 ... yes 8/10 ... yes 8/11 ... yes Redis version >= 2.8.0? ... yes Ruby version >= 2.5.3 ? ... yes (2.5.3) Git version >= 2.18.0 ? ... yes (2.18.1) Git user has default SSH configuration? ... yes Active users: ... 6 Elasticsearch version 5.6 - 6.x? ... yes (6.6.2)
Checking GitLab App ... Finished
Checking GitLab subtasks ... Finished
Possible fixes
(If you can, link to the line of code that might be responsible for the problem)