Skip to content
GitLab Next
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • GitLab GitLab
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 44,079
    • Issues 44,079
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 1,369
    • Merge requests 1,369
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.orgGitLab.org
  • GitLabGitLab
  • Issues
  • #11322
Closed (moved) (moved)
Open
Created Apr 25, 2019 by Brendan O'Leary 🐢@brendan🌻Developer

Support runtime Visual Review configuration

Problem to Solve

The Visual Review apps feature is nice but very difficult to use because you have to hardcode runtime configuration into your branch, which will result in merge conflicts and having to remember to remove the config before it merges, amongst other strangeness.

Proposal

For the next iteration we should prompt the user for the MR number they want to report on if no value is available at runtime. For teams who do have a working flow where they want to hardcode a merge request number per branch they can continue to do so, but if it is not provided it simply prompts.

Design

  • Merge request ID input step
    • Enter your merge request ID
  • Reuses existing UI
  • Link links to documentation explaining why we need the merge request ID.
  • Added in text in last state: Reports to merge request [!12343](URL). You can change that [here](URL)
    • !12343 links to the merge request
    • here links back to merge request id configuration state

image

Note: Modal UI changes have been moved to #12447 (closed)

Reference

  • As a followup to this discussion: https://gitlab.com/gitlab-org/gitlab-ee/issues/10761#note_164273318

This page may contain information related to upcoming products, features and functionality. It is important to note that the information presented is for informational purposes only, so please do not rely on the information for purchasing or planning purposes. Just like with all projects, the items mentioned on the page are subject to change or delay, and the development, release, and timing of any products, features, or functionality remain at the sole discretion of GitLab Inc.

Edited Jan 05, 2022 by 🤖 GitLab Bot 🤖
Assignee
Assign to
Time tracking