MR approvals should stop overriding the project setting upon disabling overrides
The following discussion from !10766 (merged) should be addressed:
-
@mkozono started a discussion: (+1 comment) Should
approvals_requireddecrease to the project setting whendisable_overriding_approvers_per_merge_requestchanges fromfalsetotrueandapprovals_before_mergeis set?Do we need a test for that? I didn't see one that specified this behavior, though I might have missed it.
Should this go into a follow up issue?
Steps to reproduce
- Project settings: Set
No. of approvals requiredto 3 - Project settings: Check the box
Can override approvers and approvals required per merge request - Edit an MR: Set
No. of approvals requiredto 1 - Project settings: Uncheck the box
Can override approvers and approvals required per merge request
I expect MR approvals required to be 3, but it remains at 1.
Edited by Michael Kozono