Wikis Git access panel not working when Kerberos is enabled
Git Access panel for Wikis not working when Kerberos authentication is enabled
When GitLab is configured to use Kerberos authentication, a 3rd clone URL is generated and shown to the user in the project's main dashboard and in the project's Wiki as well.
The Kerberos URL to be shown relies in a helper that invokes a method implemented in the project's model.
For the case of Wikis, that method is missing.
Steps to reproduce
- Enable Kerberos authentication
- Create a new project
test-wiki-kerberos - Visit the
Wikipanel - Visit the
Git Accesspanel
Expected behavior
The Git Access panel shows the KRB5URL to clone the test-wiki-kerberos project's Wiki.
Actual behavior
Error 500
Relevant logs and/or screenshots
ActionView::Template::Error (undefined method `kerberos_url_to_repo' for #<ProjectWiki:0x000000070f6ed0>):
18: = http_clone_button(project)
19: - if alternative_kerberos_url?
20: %li
21: = kerberos_clone_button(project)
22:
23: = text_field_tag :project_clone, default_url_to_repo(project), class: "js-select-on-focus form-control", readonly: true
24: .input-group-btn
app/helpers/button_helper.rb:65:in `kerberos_clone_button'
app/views/shared/_clone_panel.html.haml:21:in `_app_views_shared__clone_panel_html_haml__3360152183733107483_55972560'
app/views/projects/wikis/git_access.html.haml:12:in `_app_views_projects_wikis_git_access_html_haml___1352497997413490637_59103580'
lib/gitlab/request_profiler/middleware.rb:15:in `call'
lib/gitlab/middleware/rails_queue_duration.rb:20:in `call'
lib/gitlab/metrics/rack_middleware.rb:18:in `block in call'
lib/gitlab/metrics/transaction.rb:49:in `run'
lib/gitlab/metrics/rack_middleware.rb:18:in `call'
lib/gitlab/middleware/go.rb:16:in `call'
lib/gitlab/middleware/readonly_geo.rb:29:in `call'
Possible fixes
Implement in the project_wiki model the same function available in theproject's model
Patch provided in !795 (merged)