Skip to content

GitLab Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
GitLab
GitLab
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 34,929
    • Issues 34,929
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge Requests 1,241
    • Merge Requests 1,241
  • Requirements
    • Requirements
    • List
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Security & Compliance
    • Security & Compliance
    • Dependency List
    • License Compliance
  • Operations
    • Operations
    • Metrics
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • GitLab.org
  • GitLabGitLab
  • Issues
  • #11069

Closed
Open
Opened Apr 09, 2019 by Cynthia Ng@cynthiaDeveloper

SAST Support for React framework (JavaScript)

Problem to solve

Support React (JavaScript framework) as part of JavaScript SAST.

Intended users

Security Analyst, DevOps Engineer

Further details

This request came in via customer ticket (internal): https://gitlab.zendesk.com/agent/tickets/118486

Proposal

Initial Thoughts

Our documentation states that we support JavaScript through the use of ESLint Security Plugin.

However, it doesn't look like their ESLint setup includes any JSX rules, which would be needed for React.

Most likely it will need a similar setup to the ESlint React plugin.

Plan from Grooming

Add eslint-plugin-react to our eslint analyzer and restrict it to the following rules:

  • react/no-unescaped-entities
  • react/no-unsafe
  • react/jsx-no-target-blank
  • react/no-danger-with-children
  • react/no-danger

Documentation

Update SAST documentation page to describe this as a scanner and use case we support now. Update documentation to indicate how to use the scanner and ensure that it is enabled.

What does success look like, and how can we measure that?

SAST works for React based projects.

What is the type of buyer?

Existing Gold/Ultimate tier

Edited Nov 04, 2019 by Sam Kerr
Assignee
Assign to
12.6
Milestone
12.6 (Past due)
Assign milestone
Time tracking
None
Due date
None
Reference: gitlab-org/gitlab#11069