Skip to content
GitLab Next
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • GitLab GitLab
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 44,060
    • Issues 44,060
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 1,379
    • Merge requests 1,379
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.orgGitLab.org
  • GitLabGitLab
  • Issues
  • #10762
Closed
Open
Created Mar 28, 2019 by Brendan O'Leary 🐢@brendan🌻Developer

Add full screen annotations to Visual Review tool

Problem to solve

When Presley or Parker want to leave feedback through Visaul Review tool they need to be very specific in their feedback or risk having the developer miss context of what they want to change. To solve this today they are forced to take screenshots and reference those through a second comment in the MR.

Intended users

  • Presley (Product Designer)
  • Parker (Product Manager)

Further details

Proposal

With #10761 (closed), we added the ability to start a discussion from the Visual Review tool. We should add to this the ability for the user to annotate a specific area of the screen, and link back to that specific part from the resulting discussion.

For example, the implementation could look something like:

  • Inject a transparent layer on top of the entire DOM of the Review App
  • When the user is in "Visual Review" mode, allow them to click on any element on the page.
  • Record the actual coordinates of that click as part of the collected metadata and embed it into the link we'll add to the MR discussion
  • When clicking the resulting link, another user is brought back to the same point that was clicked as part of the review

Optionally, we could allow for multiple points per discussion, and this may also relate to taking screenshots of the Review App planned as part of .

image

Permissions and Security

Apply the same permisions here as are used in Visual Reviews today.

Documentation

  • Update documentation to reference how to use the annotation functionality.

Testing

What does success look like, and how can we measure that?

  • Increase usage of the Visual Review tool by counting times annotation is used.

What is the type of buyer?

Links / references

This page may contain information related to upcoming products, features and functionality. It is important to note that the information presented is for informational purposes only, so please do not rely on the information for purchasing or planning purposes. Just like with all projects, the items mentioned on the page are subject to change or delay, and the development, release, and timing of any products, features, or functionality remain at the sole discretion of GitLab Inc.

Edited Dec 07, 2021 by 🤖 GitLab Bot 🤖
Assignee
Assign to
Time tracking