Follow-up from "Show commands applied message when promoting issues to epics"

The following discussion from !9669 (merged) should be addressed:

  • @felipe_artur started a discussion: (+2 comments)

    @smcgivern I found a false positive spec when doing the CE backport. This spec is green because wait_for_requests was missing. My patch breaks it.

    If you see some lines above https://gitlab.com/gitlab-org/gitlab-ee/blob/master/spec/features/issues/user_uses_quick_actions_spec.rb#L300, it is the same case where Commands applied should be shown even when the issue has not been moved.

    This is happening because on move command there is also a check to add the update param inside the execute block. Can we resolve this in a follow up issue?

    I think the fix which makes more sense is to do all authorization checks inside the conditions block.

Assignee Loading
Time tracking Loading