Extract EE specific files/lines for Manage spec/finders
We have the following files containing EE specific code. We should move them to ee/
spec/finders/group_projects_finder_spec.rb
diff --git a/spec/finders/group_projects_finder_spec.rb b/home/yorickpeterse/Projects/gitlab/gdk-ee/gitlab/spec/finders/group_projects_finder_spec.rb
index d6d95906f5e..b6191cffa18 100644
--- a/spec/finders/group_projects_finder_spec.rb
+++ b/home/yorickpeterse/Projects/gitlab/gdk-ee/gitlab/spec/finders/group_projects_finder_spec.rb
@@ -144,6 +144,43 @@ describe GroupProjectsFinder do
end
end
+ describe 'with an admin current user' do
+ let(:current_user) { create(:admin) }
+
+ context "only shared" do
+ let(:options) { { only_shared: true } }
+ it { is_expected.to eq([shared_project_3, shared_project_2, shared_project_1]) }
+ end
+
+ context "only owned" do
+ let(:options) { { only_owned: true } }
+ it { is_expected.to eq([private_project, public_project]) }
+ end
+
+ context "all" do
+ it { is_expected.to eq([shared_project_3, shared_project_2, shared_project_1, private_project, public_project]) }
+ end
+ end
+
+ describe 'with an auditor current user' do
+ let(:current_user) { create(:user, :auditor) }
+
+ context "only shared" do
+ let(:options) { { only_shared: true } }
+ it { is_expected.to eq([shared_project_3, shared_project_2, shared_project_1]) }
+ end
+
+ context "only owned" do
+ let(:options) { { only_owned: true } }
+ it { is_expected.to eq([private_project, public_project]) }
+ end
+
+ context "all" do
+ subject { described_class.new(group: group, current_user: current_user).execute }
+ it { is_expected.to eq([shared_project_3, shared_project_2, shared_project_1, private_project, public_project]) }
+ end
+ end
+
describe "no user" do
context "only shared" do
let(:options) { { only_shared: true } }
spec/finders/users_finder_spec.rb
diff --git a/spec/finders/users_finder_spec.rb b/home/yorickpeterse/Projects/gitlab/gdk-ee/gitlab/spec/finders/users_finder_spec.rb
index fecf97dc641..f8263750c09 100644
--- a/spec/finders/users_finder_spec.rb
+++ b/home/yorickpeterse/Projects/gitlab/gdk-ee/gitlab/spec/finders/users_finder_spec.rb
@@ -52,6 +52,22 @@ describe UsersFinder do
expect(users).to contain_exactly(user, user1, user2, omniauth_user)
end
+ context 'with LDAP users' do
+ let!(:ldap_user) { create(:omniauth_user, provider: 'ldap') }
+
+ it 'returns ldap users by default' do
+ users = described_class.new(user).execute
+
+ expect(users).to contain_exactly(user, user1, user2, omniauth_user, ldap_user)
+ end
+
+ it 'returns only non-ldap users with skip_ldap: true' do
+ users = described_class.new(user, skip_ldap: true).execute
+
+ expect(users).to contain_exactly(user, user1, user2, omniauth_user)
+ end
+ end
+
it 'filters by created_at' do
filtered_user_before = create(:user, created_at: 3.days.ago)
filtered_user_after = create(:user, created_at: Time.now + 3.days)
They're all EE only tests or so. (Some we could probably just move to CE)