ee/spec/models/ci/build_spec.rb, ee/spec/requests/api/runner_spec.rb, and ee/spec/services/ci/process_pipeline_service_spec.rb are all failing
https://gitlab.com/gitlab-org/gitlab-ee/-/jobs/167927999
Failures:
1) Ci::Build#variables when environment specific variable is defined when variable environment scope is available should include {:key => "ENV_KEY", :value => "environment", :public => false}
Failure/Error: it { is_expected.to include(environment_varialbe) }
expected [{:key => "CI_PIPELINE_ID", :value => "55", :public => true, :masked => false}, {:key => "CI_PIPELINE_URL", :va...y => "CI_ENVIRONMENT_URL", :value => "https://env77.example.gitlab.com", :public => true, :masked => false}] to include {:key => "ENV_KEY", :value => "environment", :public => false}
Diff:
@@ -1,4 +1,155 @@
-:key => "ENV_KEY",
-:public => false,
-:value => "environment",
+[{:key=>"CI_PIPELINE_ID", :value=>"55", :public=>true, :masked=>false},
+ {:key=>"CI_PIPELINE_URL",
+ :value=>"http://localhost/group48/project290/pipelines/55",
+ :public=>true,
+ :masked=>false},
+ {:key=>"CI_JOB_ID", :value=>"91", :public=>true, :masked=>false},
+ {:key=>"CI_JOB_URL",
+ :value=>"http://localhost/group48/project290/-/jobs/91",
+ :public=>true,
+ :masked=>false},
+ {:key=>"CI_JOB_TOKEN",
+ :value=>"uHZjm1ZZxBnyduXxD5dD",
+ :public=>false,
+ :masked=>false},
+ {:key=>"CI_BUILD_ID", :value=>"91", :public=>true, :masked=>false},
+ {:key=>"CI_BUILD_TOKEN",
+ :value=>"uHZjm1ZZxBnyduXxD5dD",
+ :public=>false,
+ :masked=>false},
+ {:key=>"CI_REGISTRY_USER",
+ :value=>"gitlab-ci-token",
+ :public=>true,
+ :masked=>false},
+ {:key=>"CI_REGISTRY_PASSWORD",
+ :value=>"uHZjm1ZZxBnyduXxD5dD",
+ :public=>false,
+ :masked=>false},
+ {:key=>"CI_REPOSITORY_URL",
+ :value=>
+ "http://gitlab-ci-token:uHZjm1ZZxBnyduXxD5dD@localhost/group48/project290.git",
+ :public=>false,
+ :masked=>false},
+ {:key=>"CI", :value=>"true", :public=>true, :masked=>false},
+ {:key=>"GITLAB_CI", :value=>"true", :public=>true, :masked=>false},
+ {:key=>"GITLAB_FEATURES",
+ :value=>
+ "audit_events,burndown_charts,code_owners,contribution_analytics,elastic_search,export_issues,group_burndown_charts,group_webhooks,issuable_default_templates,issue_board_focus_mode,issue_weights,jenkins_integration,ldap_group_sync,member_lock,merge_request_approvers,multiple_ldap_servers,multiple_issue_assignees,multiple_project_issue_boards,push_rules,project_creation_level,protected_refs_for_users,related_issues,repository_mirrors,repository_size_limit,scoped_issue_board,file_locks,auditor_user",
+ :public=>true,
+ :masked=>false},
+ {:key=>"CI_SERVER_NAME", :value=>"GitLab", :public=>true, :masked=>false},
+ {:key=>"CI_SERVER_VERSION",
+ :value=>"11.9.0-pre",
+ :public=>true,
+ :masked=>false},
+ {:key=>"CI_SERVER_VERSION_MAJOR",
+ :value=>"11",
+ :public=>true,
+ :masked=>false},
+ {:key=>"CI_SERVER_VERSION_MINOR", :value=>"9", :public=>true, :masked=>false},
+ {:key=>"CI_SERVER_VERSION_PATCH", :value=>"0", :public=>true, :masked=>false},
+ {:key=>"CI_SERVER_REVISION",
+ :value=>"30980b47",
+ :public=>true,
+ :masked=>false},
+ {:key=>"CI_JOB_NAME", :value=>"test", :public=>true, :masked=>false},
+ {:key=>"CI_JOB_STAGE", :value=>"test", :public=>true, :masked=>false},
+ {:key=>"CI_COMMIT_SHA",
+ :value=>"b83d6e391c22777fca1ed3012fce84f633d7fed0",
+ :public=>true,
+ :masked=>false},
+ {:key=>"CI_COMMIT_SHORT_SHA",
+ :value=>"b83d6e39",
+ :public=>true,
+ :masked=>false},
+ {:key=>"CI_COMMIT_BEFORE_SHA",
+ :value=>"0000000000000000000000000000000000000000",
+ :public=>true,
+ :masked=>false},
+ {:key=>"CI_COMMIT_REF_NAME", :value=>"master", :public=>true, :masked=>false},
+ {:key=>"CI_COMMIT_REF_SLUG", :value=>"master", :public=>true, :masked=>false},
+ {:key=>"CI_NODE_TOTAL", :value=>"1", :public=>true, :masked=>false},
+ {:key=>"CI_BUILD_REF",
+ :value=>"b83d6e391c22777fca1ed3012fce84f633d7fed0",
+ :public=>true,
+ :masked=>false},
+ {:key=>"CI_BUILD_BEFORE_SHA",
+ :value=>"0000000000000000000000000000000000000000",
+ :public=>true,
+ :masked=>false},
+ {:key=>"CI_BUILD_REF_NAME", :value=>"master", :public=>true, :masked=>false},
+ {:key=>"CI_BUILD_REF_SLUG", :value=>"master", :public=>true, :masked=>false},
+ {:key=>"CI_BUILD_NAME", :value=>"test", :public=>true, :masked=>false},
+ {:key=>"CI_BUILD_STAGE", :value=>"test", :public=>true, :masked=>false},
+ {:key=>"CI_PROJECT_ID", :value=>"304", :public=>true, :masked=>false},
+ {:key=>"CI_PROJECT_NAME",
+ :value=>"project290",
+ :public=>true,
+ :masked=>false},
+ {:key=>"CI_PROJECT_PATH",
+ :value=>"group48/project290",
+ :public=>true,
+ :masked=>false},
+ {:key=>"CI_PROJECT_PATH_SLUG",
+ :value=>"group48-project290",
+ :public=>true,
+ :masked=>false},
+ {:key=>"CI_PROJECT_NAMESPACE",
+ :value=>"group48",
+ :public=>true,
+ :masked=>false},
+ {:key=>"CI_PROJECT_URL",
+ :value=>"http://localhost/group48/project290",
+ :public=>true,
+ :masked=>false},
+ {:key=>"CI_PROJECT_VISIBILITY",
+ :value=>"private",
+ :public=>true,
+ :masked=>false},
+ {:key=>"CI_PAGES_DOMAIN",
+ :value=>"example.com",
+ :public=>true,
+ :masked=>false},
+ {:key=>"CI_PAGES_URL",
+ :value=>"http://group48.example.com/project290",
+ :public=>true,
+ :masked=>false},
+ {:key=>"CI_API_V4_URL",
+ :value=>"http://localhost/api/v4",
+ :public=>true,
+ :masked=>false},
+ {:key=>"CI_PIPELINE_IID", :value=>"1", :public=>true, :masked=>false},
+ {:key=>"CI_CONFIG_PATH",
+ :value=>".gitlab-ci.yml",
+ :public=>true,
+ :masked=>false},
+ {:key=>"CI_PIPELINE_SOURCE", :value=>"push", :public=>true, :masked=>false},
+ {:key=>"CI_COMMIT_MESSAGE",
+ :value=>
+ "Merge branch 'branch-merged' into 'master'\r\n\r\nadds bar folder and branch-test text file to check Repository merged_to_root_ref method\r\n\r\n\r\n\r\nSee merge request !12",
+ :public=>true,
+ :masked=>false},
+ {:key=>"CI_COMMIT_TITLE",
+ :value=>"Merge branch 'branch-merged' into 'master'",
+ :public=>true,
+ :masked=>false},
+ {:key=>"CI_COMMIT_DESCRIPTION",
+ :value=>
+ "\r\nadds bar folder and branch-test text file to check Repository merged_to_root_ref method\r\n\r\n\r\n\r\nSee merge request !12",
+ :public=>true,
+ :masked=>false},
+ {:key=>"DB_NAME", :value=>"postgres", :public=>true, :masked=>false},
+ {:key=>"ENV_KEY", :value=>"environment", :public=>false, :masked=>false},
+ {:key=>"CI_ENVIRONMENT_NAME",
+ :value=>"staging",
+ :public=>true,
+ :masked=>false},
+ {:key=>"CI_ENVIRONMENT_SLUG",
+ :value=>"staging",
+ :public=>true,
+ :masked=>false},
+ {:key=>"CI_ENVIRONMENT_URL",
+ :value=>"https://env77.example.gitlab.com",
+ :public=>true,
+ :masked=>false}]
# ./ee/spec/models/ci/build_spec.rb:99:in `block (5 levels) in <top (required)>'
2) Ci::Build#variables when environment specific variable is defined when there is a plan for the group GITLAB_FEATURES should include the features for that plan
Failure/Error: is_expected.to include({ key: 'GITLAB_FEATURES', value: anything, public: true })
expected [{:key => "CI_PIPELINE_ID", :value => "60", :public => true, :masked => false}, {:key => "CI_PIPELINE_URL", :va...y => "CI_ENVIRONMENT_URL", :value => "https://env82.example.gitlab.com", :public => true, :masked => false}] to include {:key => "GITLAB_FEATURES", :value => #<RSpec::Mocks::ArgumentMatchers::AnyArgMatcher:0x0000564faf513330>, :public => true}
Diff:
@@ -1,4 +1,154 @@
-:key => "GITLAB_FEATURES",
-:public => true,
-:value => anything,
+[{:key=>"CI_PIPELINE_ID", :value=>"60", :public=>true, :masked=>false},
+ {:key=>"CI_PIPELINE_URL",
+ :value=>"http://localhost/group48/project295/pipelines/60",
+ :public=>true,
+ :masked=>false},
+ {:key=>"CI_JOB_ID", :value=>"96", :public=>true, :masked=>false},
+ {:key=>"CI_JOB_URL",
+ :value=>"http://localhost/group48/project295/-/jobs/96",
+ :public=>true,
+ :masked=>false},
+ {:key=>"CI_JOB_TOKEN",
+ :value=>"rpna6QYLBinSnyn7hs6V",
+ :public=>false,
+ :masked=>false},
+ {:key=>"CI_BUILD_ID", :value=>"96", :public=>true, :masked=>false},
+ {:key=>"CI_BUILD_TOKEN",
+ :value=>"rpna6QYLBinSnyn7hs6V",
+ :public=>false,
+ :masked=>false},
+ {:key=>"CI_REGISTRY_USER",
+ :value=>"gitlab-ci-token",
+ :public=>true,
+ :masked=>false},
+ {:key=>"CI_REGISTRY_PASSWORD",
+ :value=>"rpna6QYLBinSnyn7hs6V",
+ :public=>false,
+ :masked=>false},
+ {:key=>"CI_REPOSITORY_URL",
+ :value=>
+ "http://gitlab-ci-token:rpna6QYLBinSnyn7hs6V@localhost/group48/project295.git",
+ :public=>false,
+ :masked=>false},
+ {:key=>"CI", :value=>"true", :public=>true, :masked=>false},
+ {:key=>"GITLAB_CI", :value=>"true", :public=>true, :masked=>false},
+ {:key=>"GITLAB_FEATURES",
+ :value=>
+ "audit_events,burndown_charts,code_owners,contribution_analytics,elastic_search,export_issues,group_burndown_charts,group_webhooks,issuable_default_templates,issue_board_focus_mode,issue_weights,jenkins_integration,ldap_group_sync,member_lock,merge_request_approvers,multiple_ldap_servers,multiple_issue_assignees,multiple_project_issue_boards,push_rules,project_creation_level,protected_refs_for_users,related_issues,repository_mirrors,repository_size_limit,scoped_issue_board,file_locks,auditor_user",
+ :public=>true,
+ :masked=>false},
+ {:key=>"CI_SERVER_NAME", :value=>"GitLab", :public=>true, :masked=>false},
+ {:key=>"CI_SERVER_VERSION",
+ :value=>"11.9.0-pre",
+ :public=>true,
+ :masked=>false},
+ {:key=>"CI_SERVER_VERSION_MAJOR",
+ :value=>"11",
+ :public=>true,
+ :masked=>false},
+ {:key=>"CI_SERVER_VERSION_MINOR", :value=>"9", :public=>true, :masked=>false},
+ {:key=>"CI_SERVER_VERSION_PATCH", :value=>"0", :public=>true, :masked=>false},
+ {:key=>"CI_SERVER_REVISION",
+ :value=>"30980b47",
+ :public=>true,
+ :masked=>false},
+ {:key=>"CI_JOB_NAME", :value=>"test", :public=>true, :masked=>false},
+ {:key=>"CI_JOB_STAGE", :value=>"test", :public=>true, :masked=>false},
+ {:key=>"CI_COMMIT_SHA",
+ :value=>"b83d6e391c22777fca1ed3012fce84f633d7fed0",
+ :public=>true,
+ :masked=>false},
+ {:key=>"CI_COMMIT_SHORT_SHA",
+ :value=>"b83d6e39",
+ :public=>true,
+ :masked=>false},
+ {:key=>"CI_COMMIT_BEFORE_SHA",
+ :value=>"0000000000000000000000000000000000000000",
+ :public=>true,
+ :masked=>false},
+ {:key=>"CI_COMMIT_REF_NAME", :value=>"master", :public=>true, :masked=>false},
+ {:key=>"CI_COMMIT_REF_SLUG", :value=>"master", :public=>true, :masked=>false},
+ {:key=>"CI_NODE_TOTAL", :value=>"1", :public=>true, :masked=>false},
+ {:key=>"CI_BUILD_REF",
+ :value=>"b83d6e391c22777fca1ed3012fce84f633d7fed0",
+ :public=>true,
+ :masked=>false},
+ {:key=>"CI_BUILD_BEFORE_SHA",
+ :value=>"0000000000000000000000000000000000000000",
+ :public=>true,
+ :masked=>false},
+ {:key=>"CI_BUILD_REF_NAME", :value=>"master", :public=>true, :masked=>false},
+ {:key=>"CI_BUILD_REF_SLUG", :value=>"master", :public=>true, :masked=>false},
+ {:key=>"CI_BUILD_NAME", :value=>"test", :public=>true, :masked=>false},
+ {:key=>"CI_BUILD_STAGE", :value=>"test", :public=>true, :masked=>false},
+ {:key=>"CI_PROJECT_ID", :value=>"309", :public=>true, :masked=>false},
+ {:key=>"CI_PROJECT_NAME",
+ :value=>"project295",
+ :public=>true,
+ :masked=>false},
+ {:key=>"CI_PROJECT_PATH",
+ :value=>"group48/project295",
+ :public=>true,
+ :masked=>false},
+ {:key=>"CI_PROJECT_PATH_SLUG",
+ :value=>"group48-project295",
+ :public=>true,
+ :masked=>false},
+ {:key=>"CI_PROJECT_NAMESPACE",
+ :value=>"group48",
+ :public=>true,
+ :masked=>false},
+ {:key=>"CI_PROJECT_URL",
+ :value=>"http://localhost/group48/project295",
+ :public=>true,
+ :masked=>false},
+ {:key=>"CI_PROJECT_VISIBILITY",
+ :value=>"private",
+ :public=>true,
+ :masked=>false},
+ {:key=>"CI_PAGES_DOMAIN",
+ :value=>"example.com",
+ :public=>true,
+ :masked=>false},
+ {:key=>"CI_PAGES_URL",
+ :value=>"http://group48.example.com/project295",
+ :public=>true,
+ :masked=>false},
+ {:key=>"CI_API_V4_URL",
+ :value=>"http://localhost/api/v4",
+ :public=>true,
+ :masked=>false},
+ {:key=>"CI_PIPELINE_IID", :value=>"1", :public=>true, :masked=>false},
+ {:key=>"CI_CONFIG_PATH",
+ :value=>".gitlab-ci.yml",
+ :public=>true,
+ :masked=>false},
+ {:key=>"CI_PIPELINE_SOURCE", :value=>"push", :public=>true, :masked=>false},
+ {:key=>"CI_COMMIT_MESSAGE",
+ :value=>
+ "Merge branch 'branch-merged' into 'master'\r\n\r\nadds bar folder and branch-test text file to check Repository merged_to_root_ref method\r\n\r\n\r\n\r\nSee merge request !12",
+ :public=>true,
+ :masked=>false},
+ {:key=>"CI_COMMIT_TITLE",
+ :value=>"Merge branch 'branch-merged' into 'master'",
+ :public=>true,
+ :masked=>false},
+ {:key=>"CI_COMMIT_DESCRIPTION",
+ :value=>
+ "\r\nadds bar folder and branch-test text file to check Repository merged_to_root_ref method\r\n\r\n\r\n\r\nSee merge request !12",
+ :public=>true,
+ :masked=>false},
+ {:key=>"DB_NAME", :value=>"postgres", :public=>true, :masked=>false},
+ {:key=>"CI_ENVIRONMENT_NAME",
+ :value=>"staging",
+ :public=>true,
+ :masked=>false},
+ {:key=>"CI_ENVIRONMENT_SLUG",
+ :value=>"staging",
+ :public=>true,
+ :masked=>false},
+ {:key=>"CI_ENVIRONMENT_URL",
+ :value=>"https://env82.example.gitlab.com",
+ :public=>true,
+ :masked=>false}]
# ./ee/spec/models/ci/build_spec.rb:112:in `block (5 levels) in <top (required)>'
Finished in 13 minutes 49 seconds (files took 14.52 seconds to load)
331 examples, 2 failures
Failed examples:
rspec ./ee/spec/models/ci/build_spec.rb:99 # Ci::Build#variables when environment specific variable is defined when variable environment scope is available should include {:key => "ENV_KEY", :value => "environment", :public => false}
rspec ./ee/spec/models/ci/build_spec.rb:111 # Ci::Build#variables when environment specific variable is defined when there is a plan for the group GITLAB_FEATURES should include the features for that planhttps://gitlab.com/gitlab-org/gitlab-ee/-/jobs/167927451
Failures:
1) API::Runner /api/v4/jobs POST /api/v4/jobs/request for web-ide job when runner has matching tag successfully picks job
Failure/Error:
expect(json_response).to include(
"id" => build.id,
"variables" => include("key" => 'KEY', "value" => 'value', "public" => true),
"image" => a_hash_including("name" => 'ruby'),
"services" => all(a_hash_including("name" => 'mysql')),
"job_info" => a_hash_including("name" => 'terminal', "stage" => 'terminal'))
expected {"id" => 133, "token" => "gQb1rx5vESsjevSQs4M2", "allow_git_fetch" => true, "job_info" => {"name" => "terminal"..." => nil, "cache" => [nil], "credentials" => [], "dependencies" => [], "features" => {"trace_sections" => true}} to include {"variables" => (include {"key" => "KEY", "value" => "value", "public" => true})}
Diff:
@@ -1,6 +1,16 @@
+"allow_git_fetch" => true,
+"artifacts" => nil,
+"cache" => [nil],
+"credentials" => [],
+"dependencies" => [],
+"features" => {"trace_sections"=>true},
+"git_info" => {"repo_url"=>"http://gitlab-ci-token:gQb1rx5vESsjevSQs4M2@localhost/namespace469/project539.git", "ref"=>"master", "sha"=>"b83d6e391c22777fca1ed3012fce84f633d7fed0", "before_sha"=>"0000000000000000000000000000000000000000", "ref_type"=>"branch", "refspecs"=>["+refs/heads/*:refs/remotes/origin/*", "+refs/tags/*:refs/tags/*"], "depth"=>0},
"id" => 133,
-"image" => (a hash including {"name" => "ruby"}),
-"job_info" => (a hash including {"name" => "terminal", "stage" => "terminal"}),
-"services" => (all a hash including {"name" => "mysql"}),
-"variables" => (include {"key" => "KEY", "value" => "value", "public" => true}),
+"image" => {"name"=>"ruby", "entrypoint"=>nil},
+"job_info" => {"name"=>"terminal", "stage"=>"terminal", "project_id"=>541, "project_name"=>"project539"},
+"runner_info" => {"timeout"=>3600, "runner_session_url"=>nil},
+"services" => [{"name"=>"mysql", "entrypoint"=>nil, "alias"=>nil, "command"=>nil}],
+"steps" => [{"name"=>"script", "script"=>["ls", "sleep 60"], "timeout"=>3600, "when"=>"on_success", "allow_failure"=>false}],
+"token" => "gQb1rx5vESsjevSQs4M2",
+"variables" => [{"key"=>"CI_PIPELINE_ID", "value"=>"87", "public"=>true, "masked"=>false}, {"key"=>"CI_PIPELINE_URL", "value"=>"http://localhost/namespace469/project539/pipelines/87", "public"=>true, "masked"=>false}, {"key"=>"CI_JOB_ID", "value"=>"133", "public"=>true, "masked"=>false}, {"key"=>"CI_JOB_URL", "value"=>"http://localhost/namespace469/project539/-/jobs/133", "public"=>true, "masked"=>false}, {"key"=>"CI_JOB_TOKEN", "value"=>"gQb1rx5vESsjevSQs4M2", "public"=>false, "masked"=>false}, {"key"=>"CI_BUILD_ID", "value"=>"133", "public"=>true, "masked"=>false}, {"key"=>"CI_BUILD_TOKEN", "value"=>"gQb1rx5vESsjevSQs4M2", "public"=>false, "masked"=>false}, {"key"=>"CI_REGISTRY_USER", "value"=>"gitlab-ci-token", "public"=>true, "masked"=>false}, {"key"=>"CI_REGISTRY_PASSWORD", "value"=>"gQb1rx5vESsjevSQs4M2", "public"=>false, "masked"=>false}, {"key"=>"CI_REPOSITORY_URL", "value"=>"http://gitlab-ci-token:gQb1rx5vESsjevSQs4M2@localhost/namespace469/project539.git", "public"=>false, "masked"=>false}, {"key"=>"CI", "value"=>"true", "public"=>true, "masked"=>false}, {"key"=>"GITLAB_CI", "value"=>"true", "public"=>true, "masked"=>false}, {"key"=>"GITLAB_FEATURES", "value"=>"audit_events,burndown_charts,code_owners,contribution_analytics,elastic_search,export_issues,group_burndown_charts,group_webhooks,issuable_default_templates,issue_board_focus_mode,issue_weights,jenkins_integration,ldap_group_sync,member_lock,merge_request_approvers,multiple_ldap_servers,multiple_issue_assignees,multiple_project_issue_boards,push_rules,project_creation_level,protected_refs_for_users,related_issues,repository_mirrors,repository_size_limit,scoped_issue_board,file_locks,auditor_user", "public"=>true, "masked"=>false}, {"key"=>"CI_SERVER_NAME", "value"=>"GitLab", "public"=>true, "masked"=>false}, {"key"=>"CI_SERVER_VERSION", "value"=>"11.9.0-pre", "public"=>true, "masked"=>false}, {"key"=>"CI_SERVER_VERSION_MAJOR", "value"=>"11", "public"=>true, "masked"=>false}, {"key"=>"CI_SERVER_VERSION_MINOR", "value"=>"9", "public"=>true, "masked"=>false}, {"key"=>"CI_SERVER_VERSION_PATCH", "value"=>"0", "public"=>true, "masked"=>false}, {"key"=>"CI_SERVER_REVISION", "value"=>"30980b47", "public"=>true, "masked"=>false}, {"key"=>"CI_JOB_NAME", "value"=>"terminal", "public"=>true, "masked"=>false}, {"key"=>"CI_JOB_STAGE", "value"=>"terminal", "public"=>true, "masked"=>false}, {"key"=>"CI_COMMIT_SHA", "value"=>"b83d6e391c22777fca1ed3012fce84f633d7fed0", "public"=>true, "masked"=>false}, {"key"=>"CI_COMMIT_SHORT_SHA", "value"=>"b83d6e39", "public"=>true, "masked"=>false}, {"key"=>"CI_COMMIT_BEFORE_SHA", "value"=>"0000000000000000000000000000000000000000", "public"=>true, "masked"=>false}, {"key"=>"CI_COMMIT_REF_NAME", "value"=>"master", "public"=>true, "masked"=>false}, {"key"=>"CI_COMMIT_REF_SLUG", "value"=>"master", "public"=>true, "masked"=>false}, {"key"=>"CI_NODE_TOTAL", "value"=>"1", "public"=>true, "masked"=>false}, {"key"=>"CI_BUILD_REF", "value"=>"b83d6e391c22777fca1ed3012fce84f633d7fed0", "public"=>true, "masked"=>false}, {"key"=>"CI_BUILD_BEFORE_SHA", "value"=>"0000000000000000000000000000000000000000", "public"=>true, "masked"=>false}, {"key"=>"CI_BUILD_REF_NAME", "value"=>"master", "public"=>true, "masked"=>false}, {"key"=>"CI_BUILD_REF_SLUG", "value"=>"master", "public"=>true, "masked"=>false}, {"key"=>"CI_BUILD_NAME", "value"=>"terminal", "public"=>true, "masked"=>false}, {"key"=>"CI_BUILD_STAGE", "value"=>"terminal", "public"=>true, "masked"=>false}, {"key"=>"CI_PROJECT_ID", "value"=>"541", "public"=>true, "masked"=>false}, {"key"=>"CI_PROJECT_NAME", "value"=>"project539", "public"=>true, "masked"=>false}, {"key"=>"CI_PROJECT_PATH", "value"=>"namespace469/project539", "public"=>true, "masked"=>false}, {"key"=>"CI_PROJECT_PATH_SLUG", "value"=>"namespace469-project539", "public"=>true, "masked"=>false}, {"key"=>"CI_PROJECT_NAMESPACE", "value"=>"namespace469", "public"=>true, "masked"=>false}, {"key"=>"CI_PROJECT_URL", "value"=>"http://localhost/namespace469/project539", "public"=>true, "masked"=>false}, {"key"=>"CI_PROJECT_VISIBILITY", "value"=>"private", "public"=>true, "masked"=>false}, {"key"=>"CI_PAGES_DOMAIN", "value"=>"example.com", "public"=>true, "masked"=>false}, {"key"=>"CI_PAGES_URL", "value"=>"http://namespace469.example.com/project539", "public"=>true, "masked"=>false}, {"key"=>"CI_API_V4_URL", "value"=>"http://localhost/api/v4", "public"=>true, "masked"=>false}, {"key"=>"CI_PIPELINE_IID", "value"=>"1", "public"=>true, "masked"=>false}, {"key"=>"CI_CONFIG_PATH", "value"=>nil, "public"=>true, "masked"=>false}, {"key"=>"CI_PIPELINE_SOURCE", "value"=>"webide", "public"=>true, "masked"=>false}, {"key"=>"CI_COMMIT_MESSAGE", "value"=>"Merge branch 'branch-merged' into 'master'\r\n\r\nadds bar folder and branch-test text file to check Repository merged_to_root_ref method\r\n\r\n\r\n\r\nSee merge request !12", "public"=>true, "masked"=>false}, {"key"=>"CI_COMMIT_TITLE", "value"=>"Merge branch 'branch-merged' into 'master'", "public"=>true, "masked"=>false}, {"key"=>"CI_COMMIT_DESCRIPTION", "value"=>"\r\nadds bar folder and branch-test text file to check Repository merged_to_root_ref method\r\n\r\n\r\n\r\nSee merge request !12", "public"=>true, "masked"=>false}, {"key"=>"CI_RUNNER_ID", "value"=>"5", "public"=>true, "masked"=>false}, {"key"=>"CI_RUNNER_DESCRIPTION", "value"=>"My runner5", "public"=>true, "masked"=>false}, {"key"=>"CI_RUNNER_TAGS", "value"=>"tag-1", "public"=>true, "masked"=>false}, {"key"=>"KEY", "value"=>"value", "public"=>true, "masked"=>false}, {"key"=>"GITLAB_USER_ID", "value"=>"1071", "public"=>true, "masked"=>false}, {"key"=>"GITLAB_USER_EMAIL", "value"=>"user1054@example.org", "public"=>true, "masked"=>false}, {"key"=>"GITLAB_USER_LOGIN", "value"=>"user1055", "public"=>true, "masked"=>false}, {"key"=>"GITLAB_USER_NAME", "value"=>"John Doe1098", "public"=>true, "masked"=>false}],
# ./ee/spec/requests/api/runner_spec.rb:47:in `block (6 levels) in <top (required)>'
# ./spec/spec_helper.rb:185:in `block (2 levels) in <top (required)>'
Finished in 14 minutes 23 seconds (files took 16 seconds to load)
858 examples, 1 failure, 4 pending
Failed examples:
rspec ./ee/spec/requests/api/runner_spec.rb:38 # API::Runner /api/v4/jobs POST /api/v4/jobs/request for web-ide job when runner has matching tag successfully picks jobhttps://gitlab.com/gitlab-org/gitlab-ee/-/jobs/167929007
Failures:
1) Ci::ProcessPipelineService#execute cross-project pipelines creates a downstream cross-project pipeline
Failure/Error:
expect(downstream.builds.first.variables)
.to include(key: 'BRIDGE', value: 'cross', public: false)
expected [{:key => "CI_PIPELINE_ID", :value => "11", :public => true, :masked => false}, {:key => "CI_PIPELINE_URL", :va..., :public => true, :masked => false}, {:key => "BRIDGE", :value => "cross", :public => false, :masked => false}] to include {:key => "BRIDGE", :value => "cross", :public => false}
Diff:
@@ -1,4 +1,156 @@
-:key => "BRIDGE",
-:public => false,
-:value => "cross",
+[{:key=>"CI_PIPELINE_ID", :value=>"11", :public=>true, :masked=>false},
+ {:key=>"CI_PIPELINE_URL",
+ :value=>"http://localhost/namespace478/project670/pipelines/11",
+ :public=>true,
+ :masked=>false},
+ {:key=>"CI_JOB_ID", :value=>"58", :public=>true, :masked=>false},
+ {:key=>"CI_JOB_URL",
+ :value=>"http://localhost/namespace478/project670/-/jobs/58",
+ :public=>true,
+ :masked=>false},
+ {:key=>"CI_JOB_TOKEN",
+ :value=>"w9esUGzHW2XHxLQpCTpJ",
+ :public=>false,
+ :masked=>false},
+ {:key=>"CI_BUILD_ID", :value=>"58", :public=>true, :masked=>false},
+ {:key=>"CI_BUILD_TOKEN",
+ :value=>"w9esUGzHW2XHxLQpCTpJ",
+ :public=>false,
+ :masked=>false},
+ {:key=>"CI_REGISTRY_USER",
+ :value=>"gitlab-ci-token",
+ :public=>true,
+ :masked=>false},
+ {:key=>"CI_REGISTRY_PASSWORD",
+ :value=>"w9esUGzHW2XHxLQpCTpJ",
+ :public=>false,
+ :masked=>false},
+ {:key=>"CI_REPOSITORY_URL",
+ :value=>
+ "http://gitlab-ci-token:w9esUGzHW2XHxLQpCTpJ@localhost/namespace478/project670.git",
+ :public=>false,
+ :masked=>false},
+ {:key=>"CI", :value=>"true", :public=>true, :masked=>false},
+ {:key=>"GITLAB_CI", :value=>"true", :public=>true, :masked=>false},
+ {:key=>"GITLAB_FEATURES",
+ :value=>
+ "audit_events,burndown_charts,code_owners,contribution_analytics,elastic_search,export_issues,group_burndown_charts,group_webhooks,issuable_default_templates,issue_board_focus_mode,issue_weights,jenkins_integration,ldap_group_sync,member_lock,merge_request_approvers,multiple_ldap_servers,multiple_issue_assignees,multiple_project_issue_boards,push_rules,project_creation_level,protected_refs_for_users,related_issues,repository_mirrors,repository_size_limit,scoped_issue_board,file_locks,auditor_user",
+ :public=>true,
+ :masked=>false},
+ {:key=>"CI_SERVER_NAME", :value=>"GitLab", :public=>true, :masked=>false},
+ {:key=>"CI_SERVER_VERSION",
+ :value=>"11.9.0-pre",
+ :public=>true,
+ :masked=>false},
+ {:key=>"CI_SERVER_VERSION_MAJOR",
+ :value=>"11",
+ :public=>true,
+ :masked=>false},
+ {:key=>"CI_SERVER_VERSION_MINOR", :value=>"9", :public=>true, :masked=>false},
+ {:key=>"CI_SERVER_VERSION_PATCH", :value=>"0", :public=>true, :masked=>false},
+ {:key=>"CI_SERVER_REVISION",
+ :value=>"30980b47",
+ :public=>true,
+ :masked=>false},
+ {:key=>"CI_JOB_NAME", :value=>"rspec", :public=>true, :masked=>false},
+ {:key=>"CI_JOB_STAGE", :value=>"test", :public=>true, :masked=>false},
+ {:key=>"CI_COMMIT_SHA",
+ :value=>"b83d6e391c22777fca1ed3012fce84f633d7fed0",
+ :public=>true,
+ :masked=>false},
+ {:key=>"CI_COMMIT_SHORT_SHA",
+ :value=>"b83d6e39",
+ :public=>true,
+ :masked=>false},
+ {:key=>"CI_COMMIT_BEFORE_SHA",
+ :value=>"0000000000000000000000000000000000000000",
+ :public=>true,
+ :masked=>false},
+ {:key=>"CI_COMMIT_REF_NAME", :value=>"master", :public=>true, :masked=>false},
+ {:key=>"CI_COMMIT_REF_SLUG", :value=>"master", :public=>true, :masked=>false},
+ {:key=>"CI_NODE_TOTAL", :value=>"1", :public=>true, :masked=>false},
+ {:key=>"CI_BUILD_REF",
+ :value=>"b83d6e391c22777fca1ed3012fce84f633d7fed0",
+ :public=>true,
+ :masked=>false},
+ {:key=>"CI_BUILD_BEFORE_SHA",
+ :value=>"0000000000000000000000000000000000000000",
+ :public=>true,
+ :masked=>false},
+ {:key=>"CI_BUILD_REF_NAME", :value=>"master", :public=>true, :masked=>false},
+ {:key=>"CI_BUILD_REF_SLUG", :value=>"master", :public=>true, :masked=>false},
+ {:key=>"CI_BUILD_NAME", :value=>"rspec", :public=>true, :masked=>false},
+ {:key=>"CI_BUILD_STAGE", :value=>"test", :public=>true, :masked=>false},
+ {:key=>"CI_PROJECT_ID", :value=>"687", :public=>true, :masked=>false},
+ {:key=>"CI_PROJECT_NAME",
+ :value=>"project670",
+ :public=>true,
+ :masked=>false},
+ {:key=>"CI_PROJECT_PATH",
+ :value=>"namespace478/project670",
+ :public=>true,
+ :masked=>false},
+ {:key=>"CI_PROJECT_PATH_SLUG",
+ :value=>"namespace478-project670",
+ :public=>true,
+ :masked=>false},
+ {:key=>"CI_PROJECT_NAMESPACE",
+ :value=>"namespace478",
+ :public=>true,
+ :masked=>false},
+ {:key=>"CI_PROJECT_URL",
+ :value=>"http://localhost/namespace478/project670",
+ :public=>true,
+ :masked=>false},
+ {:key=>"CI_PROJECT_VISIBILITY",
+ :value=>"private",
+ :public=>true,
+ :masked=>false},
+ {:key=>"CI_PAGES_DOMAIN",
+ :value=>"example.com",
+ :public=>true,
+ :masked=>false},
+ {:key=>"CI_PAGES_URL",
+ :value=>"http://namespace478.example.com/project670",
+ :public=>true,
+ :masked=>false},
+ {:key=>"CI_API_V4_URL",
+ :value=>"http://localhost/api/v4",
+ :public=>true,
+ :masked=>false},
+ {:key=>"CI_PIPELINE_IID", :value=>"1", :public=>true, :masked=>false},
+ {:key=>"CI_CONFIG_PATH", :value=>nil, :public=>true, :masked=>false},
+ {:key=>"CI_PIPELINE_SOURCE",
+ :value=>"pipeline",
+ :public=>true,
+ :masked=>false},
+ {:key=>"CI_COMMIT_MESSAGE",
+ :value=>
+ "Merge branch 'branch-merged' into 'master'\r\n\r\nadds bar folder and branch-test text file to check Repository merged_to_root_ref method\r\n\r\n\r\n\r\nSee merge request !12",
+ :public=>true,
+ :masked=>false},
+ {:key=>"CI_COMMIT_TITLE",
+ :value=>"Merge branch 'branch-merged' into 'master'",
+ :public=>true,
+ :masked=>false},
+ {:key=>"CI_COMMIT_DESCRIPTION",
+ :value=>
+ "\r\nadds bar folder and branch-test text file to check Repository merged_to_root_ref method\r\n\r\n\r\n\r\nSee merge request !12",
+ :public=>true,
+ :masked=>false},
+ {:key=>"DB_NAME", :value=>"postgres", :public=>true, :masked=>false},
+ {:key=>"GITLAB_USER_ID", :value=>"1885", :public=>true, :masked=>false},
+ {:key=>"GITLAB_USER_EMAIL",
+ :value=>"user1865@example.org",
+ :public=>true,
+ :masked=>false},
+ {:key=>"GITLAB_USER_LOGIN",
+ :value=>"user1600",
+ :public=>true,
+ :masked=>false},
+ {:key=>"GITLAB_USER_NAME",
+ :value=>"John Doe1990",
+ :public=>true,
+ :masked=>false},
+ {:key=>"BRIDGE", :value=>"cross", :public=>false, :masked=>false}]
# ./ee/spec/services/ci/process_pipeline_service_spec.rb:40:in `block (3 levels) in <top (required)>'
Finished in 10 minutes 45 seconds (files took 13.71 seconds to load)
1210 examples, 1 failure, 5 pending
Failed examples:
rspec ./ee/spec/services/ci/process_pipeline_service_spec.rb:28 # Ci::ProcessPipelineService#execute cross-project pipelines creates a downstream cross-project pipeline